Skip to content

Default AWS_SDK_GO_VERSION to the last used version for code-generation #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2023

Conversation

a-hilaly
Copy link
Member

Default the AWS_SDK_GO_VERSION to last used version for code-generation

Will revert once, we release ARM images for all the controllers.

Signed-off-by: Amine Hilaly [email protected]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Will revert once, we release ARM images for all the controllers.

Signed-off-by: Amine Hilaly <[email protected]>
@ack-prow ack-prow bot requested review from ivelichkovich and jljaco December 26, 2023 01:06
@ack-prow ack-prow bot added the approved label Dec 26, 2023
@a-hilaly
Copy link
Member Author

/retest

@a-hilaly
Copy link
Member Author

@acornett21 looks we'll need a yq in the olm test image

@a-hilaly
Copy link
Member Author

/retest

@a-hilaly
Copy link
Member Author

/test s3-olm-test

@a-hilaly a-hilaly changed the title Default the AWS_SDK_GO_VERSION to last used version for code-generation Default AWS_SDK_GO_VERSION to the last used version for code-generation Dec 31, 2023
@ack-bot
Copy link
Collaborator

ack-bot commented Dec 31, 2023

/approve

Copy link

ack-prow bot commented Dec 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly a-hilaly merged commit 00e081f into aws-controllers-k8s:main Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants