Skip to content

Add ability to set custom sdkDelete functions #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

ndbhat
Copy link
Contributor

@ndbhat ndbhat commented Jan 11, 2024

Description of changes:
Add custom delete_operation support

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler January 11, 2024 21:25
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/lgtm

@ack-prow ack-prow bot added lgtm Indicates that a PR is ready to be merged. approved labels Jan 11, 2024
@a-hilaly
Copy link
Member

/retest

1 similar comment
@a-hilaly
Copy link
Member

/retest

@ack-prow ack-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2024
@a-hilaly
Copy link
Member

/retest

3 similar comments
@a-hilaly
Copy link
Member

/retest

@a-hilaly
Copy link
Member

/retest

@a-hilaly
Copy link
Member

/retest

@a-hilaly
Copy link
Member

/test all

@a-hilaly
Copy link
Member

/test all
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
Copy link

ack-prow bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ndbhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly a-hilaly changed the title Add custom delete_operation support Add ability to set custom sdkDelete functions Jan 16, 2024
@a-hilaly
Copy link
Member

/retest

1 similar comment
@a-hilaly
Copy link
Member

/retest

@ack-prow ack-prow bot merged commit 610c476 into aws-controllers-k8s:main Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants