Remove redundant new lines in sdk.go and role-writer templates
#489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amine Hilaly <[email protected]>
a-hilaly
force-pushed
the
rm-new-lines
branch
from
ed7ff0e to
d4dd0ff
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
a-hilaly
commented
Jan 18, 2024
| @@ -145,7 +145,7 @@ func (rm *resourceManager) sdkDelete( | |||
| exit(err) | |||
| }() | |||
|
|
|||
| {{ if .CRD.CustomDeleteMethodName }} | |||
| {{- if .CRD.CustomDeleteMethodName }} | |||
There was a problem hiding this comment.
I just made a tiny change to the custom delete method. Please make sure that is working fine acmpca-controlelr @ndbhat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant new lines in
sdk.goandrole-writer.yamltemplatesSigned-off-by: Amine Hilaly [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.