Improve nested fields path and type resolution #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the `getAttributeFromPath` function by introducing
a better field path and type resolution mechanism. Now, it considers
aadditional fallback naming conventions, particularly for cases
involving lists.
This is needed to generate type references for `Distribution` resource
in ACK CloudFront controller. More specifically, the CF API Schema for
the `Distribution` resource is naming the `FunctionAssociations` shape
`FunctionAssociationsList`.
Tested with cloudfront-controller using the following config:
```yaml
resources:
Distribution:
fields:
DistributionConfig.DefaultCacheBehavior.FunctionAssociations.Items.FunctionARN:
references:
resource: Function
path: Status.ACKResourceMetadata.ARN
```
Signed-off-by: Amine Hilaly <[email protected]>
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the
getAttributeFromPathfunction by introducinga better field path and type resolution mechanism. Now, it considers
aadditional fallback naming conventions, particularly for cases
involving lists.
This is needed to generate type references for
Distributionresourcein ACK CloudFront controller. More specifically, the CF API Schema for
the
Distributionresource is naming theFunctionAssociationsshapeFunctionAssociationsList.Tested with cloudfront-controller using the following config:
Signed-off-by: Amine Hilaly [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.