Skip to content

fix(VPCPeeringConnection): Fix update code path #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 65 commits into from
Dec 13, 2023
Merged

fix(VPCPeeringConnection): Fix update code path #163

merged 65 commits into from
Dec 13, 2023

Conversation

marcdavoli
Copy link
Contributor

@marcdavoli marcdavoli commented Dec 7, 2023 •
edited by a-hilaly
Loading

Description of changes:

  • Fixes a bug where the the values of subfields under AccepterPeeringConnectionOptions and RequesterPeeringConnectionOptions are not set properly.
  • Improves robustness of e2e tests for this resource
  • Adds an additional e2e test that uses boto3 to verify that Peering Options function normally

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@marcdavoli marcdavoli marked this pull request as draft December 7, 2023 20:45
@ack-prow ack-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 7, 2023
@ack-prow ACK Prow
Copy link

ack-prow bot commented Dec 7, 2023

Hi @marcdavoli. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marcdavoli marcdavoli changed the title fix(VPCPeeringConnection): rm omit_unchanged_field fix(VPCPeeringConnection): peeringOptions not reconciling Dec 7, 2023
@a-hilaly
Copy link
Member

a-hilaly commented Dec 7, 2023

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 7, 2023
@marcdavoli marcdavoli marked this pull request as ready for review December 13, 2023 19:37
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2023
@ack-prow ack-prow bot requested a review from jljaco December 13, 2023 19:37
a-hilaly
a-hilaly approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat stuff! Merci @marcdavoli !
/approve
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2023
@ack-prow ACK Prow
Copy link

ack-prow bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, marcdavoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 4f1f027 into aws-controllers-k8s:main Dec 13, 2023
@marcdavoli marcdavoli deleted the fix(VPCPeeringConnection)/peeringOptions-not-reconciling branch December 13, 2023 20:16
@marcdavoli marcdavoli mentioned this pull request Dec 13, 2023
Merged
ack-prow bot pushed a commit that referenced this pull request Dec 13, 2023
@marcdavoli
chore(release): v1.1.1 (#166)
f08268d 
Description of changes:
This PR creates a release v1.1.1 for ec2-controller, following the merge of PRs:
- #161 
- #163 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
nnbu pushed a commit to nnbu/ack-ec2-controller that referenced this pull request Sep 18, 2024
@marcdavoli
fix(VPCPeeringConnection): Fix update code path (aws-controllers-k8s#163
d2bcc0e 
)

- aws-controllers-k8s/community#1943

Description of changes:
- Fixes a bug where the the values of subfields under `AccepterPeeringConnectionOptions` and `RequesterPeeringConnectionOptions` are not set properly. 
- Improves robustness of e2e tests for this resource
- Adds an additional e2e test that uses boto3 to verify that Peering Options function normally

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
nnbu pushed a commit to nnbu/ack-ec2-controller that referenced this pull request Sep 18, 2024
@marcdavoli
chore(release): v1.1.1 (aws-controllers-k8s#166)
85f319e 
Description of changes:
This PR creates a release v1.1.1 for ec2-controller, following the merge of PRs:
- aws-controllers-k8s#161 
- aws-controllers-k8s#163 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@LikithaVemulapalli LikithaVemulapalli Awaiting requested review from LikithaVemulapalli

@vijtrip2 vijtrip2 Awaiting requested review from vijtrip2

@jljaco jljaco Awaiting requested review from jljaco

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcdavoli @a-hilaly