-
Notifications
You must be signed in to change notification settings - Fork 55
Update to ACK runtime v0.28.0
, code-generator v0.28.0
#168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like this is what's needed in order to support Pod Identity (see aws-controllers-k8s/community#1953 and aws-controllers-k8s/runtime#130). Currently when deployed with a pod identity, containers will crash with below:
|
4711aa5
to
343b7a3
Compare
343b7a3
to
7da16c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, ack-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@FabianPonce merging now :) |
…llers-k8s#168) ### Update to ACK runtime `v0.28.0`, code-generator `v0.28.0` ---------- * ACK code-generator `v0.28.0` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.28.0) * ACK runtime `v0.28.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.28.0) ---------- NOTE: This PR increments the release version of service controller from `v1.1.1` to `v1.1.2` Once this PR is merged, release `v1.1.2` will be automatically created for `ec2-controller` **Please close this PR, if you do not want the new patch release for `ec2-controller`** ---------- #### stdout for `make build-controller`: ``` building ack-generate ... ok. ==== building ec2-controller ==== Copying common custom resource definitions into ec2 Building Kubernetes API objects for ec2 Generating deepcopy code for ec2 Generating custom resource definitions for ec2 Building service controller for ec2 Generating RBAC manifests for ec2 Running gofmt against generated code for ec2 Updating additional GitHub repository maintenance files ==== building ec2-controller release artifacts ==== Building release artifacts for ec2-v1.1.2 Generating common custom resource definitions Generating custom resource definitions for ec2 Generating RBAC manifests for ec2 ``` ---------- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Merged PRs since last release: - aws-controllers-k8s#167 - aws-controllers-k8s#168 - aws-controllers-k8s#172 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Update to ACK runtime
v0.28.0
, code-generatorv0.28.0
v0.28.0
release notesv0.28.0
release notesNOTE:
This PR increments the release version of service controller from
v1.1.1
tov1.1.2
Once this PR is merged, release
v1.1.2
will be automatically created forec2-controller
Please close this PR, if you do not want the new patch release for
ec2-controller
stdout for
make build-controller
:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.