(fix) custom service account in helm

[grandwizard28]

Issue

While using helm, if you pass a custom name other than ack-iam-controller, then the controller pod gets stuck and shows the following error: -

2023-09-13T14:43:19.072Z	INFO	controller-runtime.metrics	Metrics server is starting to listen	{"addr": "0.0.0.0:8080"}
2023-09-13T14:43:19.073Z	INFO	setup	initializing service controller	{"aws.service": "iam"}
2023-09-13T14:43:19.278Z	INFO	setup	starting manager	{"aws.service": "iam"}
2023-09-13T14:43:19.278Z	INFO	Starting server	{"path": "/metrics", "kind": "metrics", "addr": "[::]:8080"}
I0913 14:43:19.278700       1 leaderelection.go:248] attempting to acquire leader lease ack-system/ack-iam.services.k8s.aws...
E0913 14:43:19.280349       1 leaderelection.go:330] error retrieving resource lock ack-system/ack-iam.services.k8s.aws: leases.coordination.k8s.io "ack-iam.services.k8s.aws" is forbidden: User "system:serviceaccount:ack-system:ack-iam-controller-sa" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "ack-system"

(I tried passing in ack-iam-controller-sa)

The pod is no longer able to do anything.

[ack-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: grandwizard28
Once this PR has been reviewed and has the lgtm label, please assign redbackthomson for approval by writing /assign @redbackthomson in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ack-prow]

Hi @grandwizard28. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ack-prow]

@grandwizard28: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[a-hilaly]

Hey @grandwizard28 . This code is auto generated, ideally we'd have to make this change in https://github.com/aws-controllers-k8s/code-generator/tree/main/templates/helm . Can you please ship a PR there? we're planning to ship new releases EOW at most

[grandwizard28]

Hi @a-hilaly,
A similar PR raised aws-controllers-k8s/code-generator#468.

[a-hilaly]

Thank you @grandwizard28 !
/close

[ack-prow]

@a-hilaly: Closed this PR.

In response to this:

Thank you @grandwizard28 !
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.