Review changes: rewriting code for Create in neat way

Author: Vandita2020

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,5 +1,5 @@
 ack_generate_info:
-  build_date: "2023-10-24T22:08:44Z"
+  build_date: "2024-01-02T20:26:00Z"
   build_hash: 7a92e8913d7ee7f65b761552e764e994882a49af
   go_version: go1.19
   version: v0.27.1-5-g7a92e89

pkg/resource/version/sdk.go

@@ -1,18 +1,18 @@
-res := &svcsdk.ListVersionsByFunctionInput{}
-res.FunctionName = desired.ko.Spec.FunctionName
-var list *svcsdk.ListVersionsByFunctionOutput
-list, err = rm.sdkapi.ListVersionsByFunctionWithContext(ctx, res)
-if err != nil {
-	return nil, err
-}
-versionList := list.Versions
-
-for ok := list.NextMarker != nil; ok; ok = (list.NextMarker != nil) {
-	res.Marker = list.NextMarker
-	list, err = rm.sdkapi.ListVersionsByFunctionWithContext(ctx, res)
+var marker *string = nil
+var versionList []*svcsdk.FunctionConfiguration
+for {
+	listVersionsInput := &svcsdk.ListVersionsByFunctionInput{
+		FunctionName: desired.ko.Spec.FunctionName,
+		Marker: marker,
+	}
+	listVersionResponse, err := rm.sdkapi.ListVersionsByFunctionWithContext(ctx, listVersionsInput)
 	if err != nil {
 		return nil, err
 	}
-	versionList = append(versionList, list.Versions...)
-}
-
+	versionList = append(versionList, listVersionResponse.Versions...)
+	
+	if listVersionResponse.NextMarker == nil {
+		break
+	}
+	marker = listVersionResponse.NextMarker 
+}