Skip to content

Remove terminal condition for InvalidParameterValueException #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Remove terminal condition for InvalidParameterValueException #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7520036
fix: remove terminal condition for InvalidParameterValueException
jessebye Jul 17, 2023
6dd8189
Merge branch 'main' into requeue-invalid
jessebye Jul 17, 2023
8e8ec1f
update metadata
jessebye Jul 17, 2023
0288b92
update acktest
jessebye Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2023-07-14T21:15:00Z"
build_date: "2023-07-17T23:54:05Z"
build_hash: e9b68590da73ce9143ba1e4361cebdc1d876c81e
go_version: go1.20.5
version: v0.26.1-7-ge9b6859
api_directory_checksum: 5d5c7aea8863c47e7303cc870aad4250267d93d2
api_version: v1alpha1
aws_sdk_go_version: v1.44.181
generator_config_info:
file_checksum: dfaa004dd9551888415d54b3006e115cef3dbef3
file_checksum: a3a0fb7f87067244de99c0b37aaaf917b026f03d
original_file_name: generator.yaml
last_modification:
reason: API generation
7 changes: 2 additions & 5 deletions apis/v1alpha1/generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ resources:
path: Configuration.Layers
FunctionEventInvokeConfig:
from:
operation: PutFunctionEventInvokeConfig
operation: PutFunctionEventInvokeConfig
path: .
renames:
operations:
Expand All @@ -81,9 +81,6 @@ resources:
GetFunction:
input_fields:
FunctionName: Name
exceptions:
terminal_codes:
- InvalidParameterValueException
hooks:
delta_pre_compare:
code: customPreCompare(delta, a, b)
Expand All @@ -104,7 +101,7 @@ resources:
is_required: true
references:
resource: Function
path: Spec.Name
path: Spec.Name
FunctionVersion:
is_required: true
FunctionEventInvokeConfig:
Expand Down
7 changes: 2 additions & 5 deletions generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ resources:
path: Configuration.Layers
FunctionEventInvokeConfig:
from:
operation: PutFunctionEventInvokeConfig
operation: PutFunctionEventInvokeConfig
path: .
renames:
operations:
Expand All @@ -81,9 +81,6 @@ resources:
GetFunction:
input_fields:
FunctionName: Name
exceptions:
terminal_codes:
- InvalidParameterValueException
hooks:
delta_pre_compare:
code: customPreCompare(delta, a, b)
Expand All @@ -104,7 +101,7 @@ resources:
is_required: true
references:
resource: Function
path: Spec.Name
path: Spec.Name
FunctionVersion:
is_required: true
FunctionEventInvokeConfig:
Expand Down
15 changes: 2 additions & 13 deletions pkg/resource/function/sdk.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/e2e/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
acktest @ git+https://github.com/aws-controllers-k8s/test-infra.git@10308120c62a73afb86e7aafc6be09f3d40db6c9
acktest @ git+https://github.com/aws-controllers-k8s/test-infra.git@38ce32256cc2552ab54e190cc8a8618e93af9e0c