Skip to content

Update to ACK runtime v0.28.0, code-generator v0.28.0 #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Dec 14, 2023

Update to ACK runtime v0.28.0, code-generator v0.28.0



NOTE:
This PR increments the release version of service controller from v1.3.4 to v1.3.5

Once this PR is merged, release v1.3.5 will be automatically created for lambda-controller

Please close this PR, if you do not want the new patch release for lambda-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building lambda-controller ====
Copying common custom resource definitions into lambda
Building Kubernetes API objects for lambda
Generating deepcopy code for lambda
Generating custom resource definitions for lambda
Building service controller for lambda
Generating RBAC manifests for lambda
Running gofmt against generated code for lambda
Updating additional GitHub repository maintenance files
==== building lambda-controller release artifacts ====
Building release artifacts for lambda-v1.3.5
Generating common custom resource definitions
Generating custom resource definitions for lambda
Generating RBAC manifests for lambda

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@a-hilaly
Copy link
Member

/hold need careful review

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2023
@a-hilaly a-hilaly force-pushed the ack-bot/rt-v0.28.0-codegen-v0.28.0 branch from 06d37e5 to 80e283b Compare December 22, 2023 06:17
@a-hilaly
Copy link
Member

removed all the tricky stuff so we can benefit from runtime updates and CVE patches.
/unhold

@ack-prow ack-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2023
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2023
Copy link

ack-prow bot commented Dec 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Dec 22, 2023
@ack-prow ack-prow bot merged commit 42e502c into main Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack-bot-autogen approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants