fix: Update support for DeadLetterConfig
#134
Conversation
There was a problem hiding this comment.
Looks great, thanks @Vandita2020 ! Left few comments in-line
| @@ -604,6 +604,67 @@ def test_function_architecture(self, lambda_client): | |||
| # Check Lambda function doesn't exist | |||
| assert not lambda_validator.function_exists(resource_name) | |||
|
|
|||
| def test_function_features(self, lambda_client): | |||
There was a problem hiding this comment.
This test is failing with this error message:
2024-04-01T22:47:58.673Z DEBUG ackrt << r.createResource {"kind": "Function", "namespace": "default", "name": "functionfeatures-6ihswvx", "account": "566350749442", "role": "", "region": "us-west-2", "is_adopted": false, "generation": 1, "error": "InvalidParameterValueException: The provided execution role does not have permissions to call SendMessage on SQS\n{\n RespMetadata: {\n StatusCode: 400,\n RequestID: \"ee5cd503-5f8a-4c66-a8e5-88473a1fb18a\"\n },\n Message_: \"The provided execution role does not have permissions to call SendMessage on SQS\",\n Type: \"User\"\n}"}
It looks like we need to add more permissions to Role we create during the bootstrap. Maybe we can introduce a new role for DLQ
There was a problem hiding this comment.
Thanks for pointing out the error, I have used another Role now. This role will give permission to access SQS.
| runtime: python3.9 | ||
| handler: main | ||
| deadLetterConfig: | ||
| targetARN: $TARGET_ARN |
There was a problem hiding this comment.
tiny nit:
| targetARN: $TARGET_ARN | |
| targetARN: $DEAD_LETTER_CONFIG_TARGET_ARN |
Vandita2020
force-pushed
the
update_dead_letter_config
branch
2 times, most recently
from
f70289f to
a3999d4
Compare
Vandita2020
force-pushed
the
update_dead_letter_config
branch
from
a3999d4 to
0d71257
Compare
Vandita2020
force-pushed
the
update_dead_letter_config
branch
from
0d71257 to
0e4be83
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, Vandita2020 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description:
This PR adds the missing update feature for
DeadLetterConfigproperty in Function resource.Acknowledgement:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.