Add resource reference for Amazon MQ brokers in EventSourceMapping resource
#64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
reviewed
Nov 4, 2022
apis/v1alpha1/generator.yaml
Outdated
| @@ -97,6 +97,11 @@ resources: | |||
| ignore: true | |||
| EventSourceMapping: | |||
| fields: | |||
| AmazonManagedKafkaEventSourceConfig: | |||
There was a problem hiding this comment.
I think you meant Queues here :)
We still don't have an AMK controller to support resource references with/for EventSourceConfigs
There was a problem hiding this comment.
Thanks, I corrected it.
…tSourceMapping resource
a-hilaly
changed the title
EventSourceMapping resource
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, Vandita2020 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
michaelhtm
pushed a commit
to rushmash91/lambda-controller
that referenced
this pull request
Feb 5, 2025
…llers-k8s#64) Co-authored-by: ci-robot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of manually passing the broker name, this feature will allow ACK lambda-controller users to cross-reference ACK MQ broker in their EventSourceMapping resource
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.