Adding delete all layer versions functionality for layerVersion resource #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ack-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
Vandita2020
force-pushed
the
layer_version_delete
branch
from
ef13d00 to
a7a08e1
Compare
a-hilaly
reviewed
Jan 5, 2023
Vandita2020
force-pushed
the
layer_version_delete
branch
from
a7a08e1 to
5115fa4
Compare
|
/test all |
Vandita2020
force-pushed
the
layer_version_delete
branch
from
5115fa4 to
f08445f
Compare
|
/test all |
Vandita2020
force-pushed
the
layer_version_delete
branch
from
f08445f to
a432205
Compare
|
/test all |
Vandita2020
force-pushed
the
layer_version_delete
branch
from
a432205 to
a946469
Compare
|
/test all |
Vandita2020
force-pushed
the
layer_version_delete
branch
from
a946469 to
0b91d2f
Compare
|
/test all |
ack-bot
removed
the
do-not-merge/work-in-progress
RedbackThomson
suggested changes
Jan 18, 2023
templates/hooks/layerversion/sdk_delete_pre_build_request.go.tpl
Outdated
Show resolved
Hide resolved
Vandita2020
force-pushed
the
layer_version_delete
branch
from
0b91d2f to
53fb12a
Compare
a-hilaly
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Good job on this @Vandita2020 !
Leaving the lgtm-ing for @RedbackThomson
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, Vandita2020 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Vandita2020
force-pushed
the
layer_version_delete
branch
from
53fb12a to
1f32bd1
Compare
|
/test all |
1 similar comment
|
/test all |
Vandita2020
requested review from
RedbackThomson
and removed request for
vijtrip2
Vandita2020
force-pushed
the
layer_version_delete
branch
from
61e1024 to
b713418
Compare
RedbackThomson
approved these changes
Feb 1, 2023
Comment on lines
+25
to
+27
| // customPreDelete deletes all the previous versions of a | ||
| // LayerVersion except the latest version | ||
| // This function is used as a sdk_delete hook, to delete all the previous versions of a LayerVersion when delete API call is made |
There was a problem hiding this comment.
tiny nit: These comments seem to be saying the same thing.
Vandita2020
force-pushed
the
layer_version_delete
branch
from
1081dc6 to
232baf7
Compare
|
/test all |
Vandita2020
force-pushed
the
layer_version_delete
branch
from
232baf7 to
575d12c
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, RedbackThomson, Vandita2020 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
michaelhtm
pushed a commit
to rushmash91/lambda-controller
that referenced
this pull request
Feb 5, 2025
…llers-k8s#70) ### Update to ACK runtime `v0.29.2`, code-generator `v0.29.2` ---------- * ACK code-generator `v0.29.2` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.29.2) * ACK runtime `v0.29.2` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.29.2) ---------- NOTE: This PR increments the release version of service controller from `v0.0.29` to `v0.0.30` Once this PR is merged, release `v0.0.30` will be automatically created for `mq-controller` **Please close this PR, if you do not want the new patch release for `mq-controller`** ---------- #### stdout for `make build-controller`: ``` building ack-generate ... ok. ==== building mq-controller ==== Copying common custom resource definitions into mq Building Kubernetes API objects for mq Generating deepcopy code for mq Generating custom resource definitions for mq Building service controller for mq Generating RBAC manifests for mq Running gofmt against generated code for mq Updating additional GitHub repository maintenance files ==== building mq-controller release artifacts ==== Building release artifacts for mq-v0.0.30 Generating common custom resource definitions Generating custom resource definitions for mq Generating RBAC manifests for mq ``` ---------- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently when you delete a LayerVersion it deletes the most recent version of it and keep the previous versions. The functionality we want is to delete all the versions of a LayerVersion when DeleteLayerVersion is executed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.