Skip to content

Add functionality to pass reference of AmazonManagedKafka (MSK) in EventSourceMapping resource #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

Vandita2020
Copy link
Member

@Vandita2020 Vandita2020 commented Jun 26, 2023

Issue #, if available:
#1394

Description of changes:

This PR adds functionality to pass reference for ARN of AmazonManagedKafka cluster to EventSourceArn inEventSourceMapping resource.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
Copy link

ack-prow bot commented Jun 26, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2023
@ack-prow ack-prow bot requested review from a-hilaly and jljaco June 26, 2023 22:32
@Vandita2020 Vandita2020 changed the title Add AMKArn reference field in EventSourceMapping resource Add functionality to pass reference of AmazonManagedKafka in EventSourceMapping resource Jun 27, 2023
@Vandita2020 Vandita2020 changed the title Add functionality to pass reference of AmazonManagedKafka in EventSourceMapping resource Add functionality to pass reference of AmazonManagedKafka (MSK) in EventSourceMapping resource Jun 27, 2023
@Vandita2020 Vandita2020 marked this pull request as ready for review June 27, 2023 22:23
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2023
@ack-prow ack-prow bot requested a review from RedbackThomson June 27, 2023 22:23
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Vandita2020 !
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
@ack-prow
Copy link

ack-prow bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, Vandita2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Jun 28, 2023
@ack-prow ack-prow bot merged commit beba0f9 into aws-controllers-k8s:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants