-
Notifications
You must be signed in to change notification settings - Fork 20
feat: Adding E2E metric test for RDS database interactions #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding E2E metric test for RDS database interactions #102
Conversation
…ws-observability#102) *Issue #, if available:* Copy workflow in aws-observability#12 to this repository, with some additional changes. This workflow is used in the main-build workflow. *Description of changes:* - Added Python EKS E2E workflow - Main build workflow to use Python EKS E2E workflow - Updated `artifacts_build/action.yml` to also upload staging image to E2E test account *Testing*: https://github.com/aws-observability/aws-otel-python-instrumentation/actions/runs/8208711023 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why no log or trace validation?
- Can we see the test in more than one region?
- Some proof that the resources in the accounts that run the canary are configured in a way that will accept the same changes as these that make the test pass in your dev environment would also be great. You can use the testing instructions in the automated PR description for that, although you're on a fork so it won't work...
@majanjua-amzn Thanks for your review!
log and trace validation will be in separate PRs. They are in draft mode at the moment, I will polish them once this one is merged.
Em... looks like it's hard to have infra in two regions together. I may need to delete my us-east-1 stack and re-deploy to another region and modify the
The infra created in my personal account is using the CDK package to deploy a personal stack. Then I created a secret stored in secrets manager called |
2889381
to
ced22a1
Compare
Change has been running continuously every 15 minutes for two days: https://github.com/jerry-shao/aws-application-signals-test-framework/actions?query=branch%3Amain The missing runs were due to a known problem: docker throttling CloudWatch metric: ![]() |
)" This reverts commit f2667a4.
Issue description:
The E2E test workflow now calls
/mysql
API which generates a SQL query to RDS database. However, we are not testing the telemetries ingested by this Agent yet.Description of changes:
This is the first change to test telemetry ingested by Application Signals agent for SQL query interruptions.
This change calls CloudWatch Metrics for ListMetrics API and compares with the expected metric list.
E2E test workflow for us-east-1: https://github.com/jerry-shao/aws-application-signals-test-framework/actions/runs/9961505823/job/27523164038
No failure:

Ensure you've run the following tests on your changes and include the link below:
To do so, create a
test.yml
file withname: Test
and workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.
e2e-playground
in us-east-1 and eu-central-2e2e-playground
in us-east-1 and eu-central-2e2e-playground
in us-east-1 and eu-central-2By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.