Adds E2E tracing test for RDS database interactions for Python #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds tracing test for rds database interactions for Python programming language.
This was referenced Jul 24, 2024
jerry-shao
reviewed
Jul 25, 2024
validator/src/main/resources/expected-data-template/python/eks/rds-mysql-trace.mustache
Outdated
Show resolved
Hide resolved
validator/src/main/resources/expected-data-template/python/eks/rds-mysql-trace.mustache
Outdated
Show resolved
Hide resolved
validator/src/main/resources/expected-data-template/python/eks/rds-mysql-trace.mustache
Outdated
Show resolved
Hide resolved
validator/src/main/resources/expected-data-template/python/eks/rds-mysql-trace.mustache
Outdated
Show resolved
Hide resolved
validator/src/main/resources/expected-data-template/python/eks/rds-mysql-trace.mustache
Outdated
Show resolved
Hide resolved
validator/src/main/resources/expected-data-template/python/eks/rds-mysql-trace.mustache
Outdated
Show resolved
Hide resolved
validator/src/main/resources/expected-data-template/python/eks/rds-mysql-trace.mustache
Outdated
Show resolved
Hide resolved
jerry-shao
reviewed
Jul 29, 2024
This reverts commit 85f161c.
majanjua-amzn
approved these changes
Aug 2, 2024
georgeboc
added a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Aug 2, 2024
majanjua-amzn
pushed a commit
that referenced
this pull request
Aug 2, 2024
#128)" (#153) *Issue description:* This reverts commit 0cd976e, as we saw that it was failing the workflow: - https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/10219677752/job/28278422311 - https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/10219840089/job/28278937793
georgeboc
added a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Aug 2, 2024
…thon (aws-observability#128)" This reapplies commit 0cd976e.
georgeboc
added a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Aug 2, 2024
…thon (aws-observability#128)" This reapplies commit 0cd976e.
majanjua-amzn
pushed a commit
that referenced
this pull request
Aug 2, 2024
georgeboc
added a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Aug 2, 2024
…s for Python (aws-observability#128)" (aws-observability#154)" This reverts commit 4a88259.
majanjua-amzn
pushed a commit
that referenced
this pull request
Aug 2, 2024
georgeboc
added a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Aug 9, 2024
…thon (aws-observability#128)" This reverts commit 47c11e7.
georgeboc
added a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Aug 12, 2024
…thon (aws-observability#128)" This reverts commit 3c3eefd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description: This commit adds a tracing test for the RDS database interactions for the Python programming language.
Description of changes: We are validating the traces returned against a template to the end-to-end test to ensure we detect any regressions, similarly as we are doing for Java in this other PR. We are particularly interested in the following fields:
aws.remote.resource.typeaws.remote.resource.identifieraws.remote.serviceaws.remote.operationThis change was tested in this fork.
Ensure you've run the following tests on your changes and include the link below:
To do so, create a
test.ymlfile withname: Testand workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.
e2e-playgroundin us-east-1 and eu-central-2e2e-playgroundin us-east-1 and eu-central-2e2e-playgroundin us-east-1 and eu-central-2By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.