Logging stacktrace for the exception if MetricValidation failed for each retry #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
Today, when E2E test for metrics failed to get expected metrics, it retries for maximum 80 times. However, it won't tell us which metric was missing until it exhaust all retries at the very end. Example: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/10082523244/job/27876967293#step:27:100
Description of changes:
This change logs stacktrace of the failed attempt in warning level, so operator will see the missing metric even after one retry.
Example stacktrace in workflow log:
Test run: https://github.com/jerry-shao/aws-application-signals-test-framework/actions/runs/10167100950/job/28118707771
Ensure you've run the following tests on your changes and include the link below:
To do so, create a
test.yml
file withname: Test
and workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.
e2e-playground
in us-east-1 and eu-central-2e2e-playground
in us-east-1 and eu-central-2e2e-playground
in us-east-1 and eu-central-2By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.