Remove docker runner container image #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrryr
force-pushed
the
remove-docker-image-runner
branch
5 times, most recently
from
5065cea to
9674063
Compare
harrryr
force-pushed
the
remove-docker-image-runner
branch
from
9674063 to
af305c2
Compare
harrryr
force-pushed
the
remove-docker-image-runner
branch
3 times, most recently
from
7a3d2d1 to
24adbd9
Compare
harrryr
force-pushed
the
remove-docker-image-runner
branch
from
24adbd9 to
62664b0
Compare
majanjua-amzn
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
To resolve issues where downloading dependencies caused failures in E2E workflows due to transient issues, we began running E2E workflows in a docker image container with those dependencies already installed in this PR.
As we started scaling our canary to encompass more platforms and regions however, the public ECR storing the image started throttling. Despite efforts to mitigate this throttle by increasing the API limit and also distributing the image to multiple public ECRs, the throttling still occurs and we are currently unable to determine the precise reason why.
After discussion, we have decided to revert from using image containers and explore other solutions to mitigate these transient issues such as caching.
Description of changes:
Stop using image containers in the github runners and add back the retry logic to install Terraform and other dependencies.
Test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/10171443800
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.