Skip to content

Update Sample Apps aws-sdk-call param name to indicate Test ID #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented Mar 15, 2024

Issue #, if available:
Followup on #7
In the future, when new metric rollup tests are added for aws-sdk-call, the S3 bucket name will have the workflow Testing ID appended to it, not the IP.

Description of changes:
Rename parameter ip to testingId for aws-sdk-call endpoint in each sample app

Testing:
Python and Java updated sample apps were uploaded to personal AWS account's S3 and ECR to be used in the following test runs:

IAD - EKS Java - https://github.com/jj22ee/aws-application-signals-test-framework/actions/runs/8303126176
IAD - EC2 Java - https://github.com/jj22ee/aws-application-signals-test-framework/actions/runs/8303094447
IAD - EKS Python - https://github.com/jj22ee/aws-application-signals-test-framework/actions/runs/8303096750
IAD - EC2 Python - https://github.com/jj22ee/aws-application-signals-test-framework/actions/runs/8303095306

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jj22ee jj22ee requested a review from majanjua-amzn March 15, 2024 19:27
@majanjua-amzn
Copy link
Contributor

Also, make sure any calls made to /aws-sdk-call also either do not use this (as it should be optional) or provide the testing ID as the appended value

@jj22ee
Copy link
Contributor Author

jj22ee commented Mar 15, 2024

The testing done indicates that these parameters are indeed optional as testingId is not used in the tests.

@jj22ee
Copy link
Contributor Author

jj22ee commented Mar 18, 2024

Manual tests:

Java

  1. cd aws-application-signals-test-framework/sample-apps/springboot
  2. gradle run
  3. Run commands curl http://localhost:8080/aws-sdk-call and curl http://localhost:8080/aws-sdk-call?testingId=us-east-1-32432432.
  4. Check Sample app logs:
2024-03-18 15:31:55.777 ERROR 76948 --- [nio-8080-exec-5] c.a.sampleapp.FrontendServiceController  : Error occurred when trying to get bucket location of: e2e-test-bucket-name
2024-03-18 15:31:55.777 ERROR 76948 --- [nio-8080-exec-5] c.a.sampleapp.FrontendServiceController  : Could not retrieve http request:The specified bucket does not exist (Service: S3, Status Code: 404, Request ID: PC20XAMDGQJ5DNHN, Extended Request ID: dHQjUKggtIgT8qdxq908oVS5ABVVRrlfJV96UYC1/wLG4mCkA/hiYOWFWa1ZV4z+ZnNxyXUrWrI=)
2024-03-18 15:32:05.870 ERROR 76948 --- [nio-8080-exec-7] c.a.sampleapp.FrontendServiceController  : Error occurred when trying to get bucket location of: e2e-test-bucket-name-us-east-1-32432432
2024-03-18 15:32:05.870 ERROR 76948 --- [nio-8080-exec-7] c.a.sampleapp.FrontendServiceController  : Could not retrieve http request:The specified bucket does not exist (Service: S3, Status Code: 404, Request ID: 9VRY7CS50J0XCPMQ, Extended Request ID: sps8Wnuv6CE7JJyuO4ssvqAwcRhHK7ovha4W5dg1HqSBPFKC2TaSY0UgyUU4vtSe14/7Vb8HU0s=)

Python:

  1. cd aws-application-signals-test-framework/sample-apps/python
  2. docker compose up
  3. Run commands curl http://localhost:8000/aws-sdk-call and curl http://localhost:8000/aws-sdk-call?testingId=us-east-1-32432432.
  4. Check Sample app logs:
django_frontend_service  | Error occurred when trying to get bucket location of: e2e-test-bucket-name
django_frontend_service  | Could not retrieve http request:Unable to locate credentials
django_frontend_service  | [18/Mar/2024 22:35:30] "GET /aws-sdk-call HTTP/1.1" 200 50
django_frontend_service  | Error occurred when trying to get bucket location of: e2e-test-bucket-name-us-east-1-32432432
django_frontend_service  | Could not retrieve http request:Unable to locate credentials
django_frontend_service  | [18/Mar/2024 22:35:39] "GET /aws-sdk-call?testingId=us-east-1-32432432 HTTP/1.1" 200 50

@jj22ee jj22ee merged commit 334887d into aws-observability:main Mar 18, 2024
@jj22ee jj22ee deleted the update-sample-app-param branch March 18, 2024 23:14
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…-param

Update Sample Apps aws-sdk-call param name to indicate Test ID
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…-param

Update Sample Apps aws-sdk-call param name to indicate Test ID
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…-param

Update Sample Apps aws-sdk-call param name to indicate Test ID
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…-param

Update Sample Apps aws-sdk-call param name to indicate Test ID
georgeboc pushed a commit to georgeboc/aws-application-signals-test-framework that referenced this pull request Jul 8, 2024
In this commit we are moving constants out of classes and into modules,
to make it easier to reference them in code. Also, we are removing
AWS_*_NAME attributes fomr AwsAttributeKeys, since these attributes are
not present in Python implementation.

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants