-
Notifications
You must be signed in to change notification settings - Fork 20
Update Sample Apps aws-sdk-call param name to indicate Test ID #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jj22ee
merged 2 commits into
aws-observability:main
from
jj22ee:update-sample-app-param
Mar 18, 2024
Merged
Update Sample Apps aws-sdk-call param name to indicate Test ID #19
jj22ee
merged 2 commits into
aws-observability:main
from
jj22ee:update-sample-app-param
Mar 18, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sample-apps/springboot/src/main/java/com/amazon/sampleapp/FrontendServiceController.java
Outdated
Show resolved
Hide resolved
sample-apps/python/django_frontend_service/frontend_service_app/views.py
Outdated
Show resolved
Hide resolved
Also, make sure any calls made to |
The testing done indicates that these parameters are indeed optional as |
Manual tests: Java
Python:
|
majanjua-amzn
approved these changes
Mar 18, 2024
sample-apps/springboot/src/main/java/com/amazon/sampleapp/FrontendServiceController.java
Show resolved
Hide resolved
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…-param Update Sample Apps aws-sdk-call param name to indicate Test ID
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…-param Update Sample Apps aws-sdk-call param name to indicate Test ID
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…-param Update Sample Apps aws-sdk-call param name to indicate Test ID
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…-param Update Sample Apps aws-sdk-call param name to indicate Test ID
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
In this commit we are moving constants out of classes and into modules, to make it easier to reference them in code. Also, we are removing AWS_*_NAME attributes fomr AwsAttributeKeys, since these attributes are not present in Python implementation. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Followup on #7
In the future, when new metric rollup tests are added for
aws-sdk-call
, the S3 bucket name will have the workflowTesting ID
appended to it, not the IP.Description of changes:
Rename parameter
ip
totestingId
foraws-sdk-call
endpoint in each sample appTesting:
Python and Java updated sample apps were uploaded to personal AWS account's S3 and ECR to be used in the following test runs:
IAD - EKS Java - https://github.com/jj22ee/aws-application-signals-test-framework/actions/runs/8303126176
IAD - EC2 Java - https://github.com/jj22ee/aws-application-signals-test-framework/actions/runs/8303094447
IAD - EKS Python - https://github.com/jj22ee/aws-application-signals-test-framework/actions/runs/8303096750
IAD - EC2 Python - https://github.com/jj22ee/aws-application-signals-test-framework/actions/runs/8303095306
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.