Increase metric validation wait time to ~15 minutes #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrryr
force-pushed
the
fix-eu-central-2-metric-error
branch
from
35ffd77 to
c81f531
Compare
majanjua-amzn
approved these changes
Mar 18, 2024
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…-central-2-metric-error Increase metric validation wait time to ~15 minutes
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…-central-2-metric-error Increase metric validation wait time to ~15 minutes
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…-central-2-metric-error Increase metric validation wait time to ~15 minutes
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…-central-2-metric-error Increase metric validation wait time to ~15 minutes
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
AwsMetricAttributeGeneratorjava generates the key metrics used by the AwsSpanMetric Processor and Exporter. With some exceptions, this is a roughly-carbon-copy file of https://github.com/aws-observability/aws-otel-java-instrumentation/blob/main/awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/AwsMetricAttributeGenerator.java Exceptions: * The following classes are not implemented as they solve problems that are specific to Java and we need to pathfind their solutions in Python: * _get_aws_status_code * _normalize_service_name * _get_remote_target * _generate_remote_operation URL parsing logic is slighly different compared to Java's generateRemoteOperation: * In Java. we will not parse the http url if a Malformed exception is thrown. In Python no such exception is thrown, so we always parse. * Per documentation [1] Malformed exception is only thrown if the protocol (http/https) is malformed or not recognized. I confirmed with @Xiami that this is just a quirk of Java and has no real bearing on the funcitonality, since per OTEL spec, http_url must be well formed [1] https://docs.oracle.com/javase/8/docs/api/java/net/URL.html#URL-java.lang.String- By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The eu-central-2 eks canary frequently fails due to missing metric during the metric validation phase. Previously, the metric validation retry time was increased from ~2 minutes to ~6 minutes, but the validation issue persisted.
Testing shows that the missing metrics takes time to appear and it takes up to around ~12 minutes.
Description of changes:
Increase the retry time during the metric validation phase to ~15 minutes. This will very likely cause the canary to frequently be delayed by ~5 minutes, but since usual runs are around ~9 minute and this error occurs around once a day, it should be able to catch back up to schedule.
Test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8324877527/job/22777377535
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.