Skip to content

Update E2E Test Validation for EKS Add-on v1.3.1 version 2 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

harrryr
Copy link
Contributor

@harrryr harrryr commented Mar 25, 2024

Issue #, if available:
Follow up on this PR after having to revert due to failures in the canary. We previously had to revert because changes relating to the inferred node and the change from _ to . had not yet been propagated to all regions of AWS X-Ray

Description of changes:
Same changes as #18 but with the inferred node added back.

Test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8447659625

Test run after adding inferred node of client-call trace back in: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8526106795

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@harrryr harrryr force-pushed the revert-27-revert-18-update-validation-to-addon-1.3.1 branch 3 times, most recently from cddd4f1 to e2e46ef Compare March 27, 2024 06:49
@majanjua-amzn majanjua-amzn force-pushed the revert-27-revert-18-update-validation-to-addon-1.3.1 branch from 7f5d8cd to 9be9df2 Compare April 2, 2024 16:34
@majanjua-amzn majanjua-amzn merged commit 5c643e5 into main Apr 2, 2024
@zzhlogin zzhlogin deleted the revert-27-revert-18-update-validation-to-addon-1.3.1 branch June 6, 2024 18:19
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…-27-revert-18-update-validation-to-addon-1.3.1

Update E2E Test Validation to use latest EKS addon
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…-27-revert-18-update-validation-to-addon-1.3.1

Update E2E Test Validation to use latest EKS addon
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…-27-revert-18-update-validation-to-addon-1.3.1

Update E2E Test Validation to use latest EKS addon
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…-27-revert-18-update-validation-to-addon-1.3.1

Update E2E Test Validation to use latest EKS addon
georgeboc pushed a commit to georgeboc/aws-application-signals-test-framework that referenced this pull request Jul 8, 2024
…rvability#30)

*Description of changes:*
Implement Unit Test for AWS Metric Attributes Span Exporter

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

---------

Co-authored-by: ADOT Patch workflow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants