Skip to content

Revert "Run E2E Test in docker container with packages already installed" #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

harrryr
Copy link
Contributor

@harrryr harrryr commented Apr 8, 2024

Reverts #33

@vastin
Copy link
Contributor

vastin commented Apr 8, 2024

LGTM

@vastin vastin self-requested a review April 8, 2024 19:20
Copy link
Contributor

@vastin vastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harrryr harrryr merged commit 4557838 into main Apr 8, 2024
@zzhlogin zzhlogin deleted the revert-33-build-docker-for-e2e branch June 6, 2024 18:14
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…-33-build-docker-for-e2e

Revert "Run E2E Test in docker container with packages already installed"
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…-33-build-docker-for-e2e

Revert "Run E2E Test in docker container with packages already installed"
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…-33-build-docker-for-e2e

Revert "Run E2E Test in docker container with packages already installed"
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
…-33-build-docker-for-e2e

Revert "Run E2E Test in docker container with packages already installed"
georgeboc pushed a commit to georgeboc/aws-application-signals-test-framework that referenced this pull request Jul 8, 2024
…y#35)

*Issue #, if available:*
If input a None type of span name, it will trigger an exception
*Description of changes:*
add a validate step to handle none type span name

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants