[EKS] Separating concurrency tag to be per region #37
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…ncurrency [EKS] Separating concurrency tag to be per region
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…ncurrency [EKS] Separating concurrency tag to be per region
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…ncurrency [EKS] Separating concurrency tag to be per region
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…ncurrency [EKS] Separating concurrency tag to be per region
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
) *Description of changes:* Implement Unit Test for Metric Attribute Generator By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. --------- Co-authored-by: ADOT Patch workflow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current state, if an EKS E2E test in a single region runs long then all regions will not be able to proceed until that one region is done running its test. This creates cross-region dependencies on our E2E test canary despite them being hosted on entirely separate infrastructure, and can cause false alarms to go off in all regions. As such, I've moved the concurrency tag accordingly and added the region to it so there is no interference
Description of changes:
groupattributeTesting:
I do not have the infrastructure set up in my personal fork/account to run this commit as a canary, but I ran the workflows in the following commits twice to show the logic is functional and when checking the workflow runs the one that started second did wait for the first to complete appropriately and only at a regional level. Commits:
Commit 1: link
Commit 2: link
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.