Update Gradlew Daemon to use existing build in cache #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrryr
force-pushed
the
update-dockerfile
branch
2 times, most recently
from
1748faa to
6c84933
Compare
zzhlogin
reviewed
Apr 17, 2024
zzhlogin
approved these changes
Apr 18, 2024
harrryr
force-pushed
the
update-dockerfile
branch
2 times, most recently
from
749cb12 to
734539e
Compare
harrryr
force-pushed
the
update-dockerfile
branch
from
734539e to
31c4966
Compare
zzhlogin
approved these changes
Apr 18, 2024
Merged
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…-dockerfile Update Gradlew Daemon to use existing build in cache
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…-dockerfile Update Gradlew Daemon to use existing build in cache
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…-dockerfile Update Gradlew Daemon to use existing build in cache
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…-dockerfile Update Gradlew Daemon to use existing build in cache
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
### Description of changes: Updated the `_generate_remote_service` function to fallback to parsing the `_HTTP_URL` attribute for the host and port and generate remote_service from them. This will be the back up behavior until `_NET_PEER*` gets populated properly. GitHub issue: open-telemetry/opentelemetry-python-contrib#2138. ### Testing Tested it locally to see that the `aws_remote_service` is being populated properly. Tested by deploying the code changes to EKS and nodes were linking together properly instead of the vehicle-service pointing to UnknownRemoteService.  By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
When the gradlew daemon restarts it needs to download dependency to build the .jar files. This can cause transient issues if the download fails
Description of changes:
Make the daemon use cached build from ~/.gradle/build instead
We know this is working because if you look at the test run, it shows
FROM-CACHEat the end of each build.Test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8717247804
Test run after comment: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8727081926
Test run after adding retries and wait time: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8730663803/job/23954844966
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.