Skip to content

Edit retry mechanism #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Edit retry mechanism #44

merged 3 commits into from
Apr 18, 2024

Conversation

harrryr
Copy link
Contributor

@harrryr harrryr commented Apr 17, 2024

Issue #, if available:
Making the following changes for the retry script/action

  • Add echo to indicate start/end point of the script plus additional other echo
  • Fix bug in if statement that causes the exit 1 to not execute
  • Add sleep time as a variable

Test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8720954180
Retry action fail test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8726951558/job/23943355253#step:12:99
Retry script fail test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8726900452/job/23943187838#step:14:554
Test run after some more change: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8726986206
Test run after changing ordering: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8730300582/job/23954033571
Fail Test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8730465819

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@harrryr harrryr force-pushed the edit-retry-mechanism branch from ca59387 to 19dbc13 Compare April 17, 2024 18:35
@harrryr harrryr force-pushed the edit-retry-mechanism branch from 19dbc13 to 8cf0f20 Compare April 17, 2024 18:37
@harrryr harrryr force-pushed the edit-retry-mechanism branch from 3bbee55 to 61a4b73 Compare April 17, 2024 23:52
@harrryr harrryr force-pushed the edit-retry-mechanism branch from 6c9cb6a to 20398b3 Compare April 18, 2024 00:25
@harrryr harrryr force-pushed the edit-retry-mechanism branch from 019fbb8 to 997a46f Compare April 18, 2024 00:41
@harrryr harrryr merged commit 5bfea39 into main Apr 18, 2024
@harrryr harrryr deleted the edit-retry-mechanism branch April 18, 2024 00:43
@zzhlogin zzhlogin mentioned this pull request Apr 22, 2024
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
zzhlogin pushed a commit to zzhlogin/aws-application-signals-test-framework that referenced this pull request Jun 6, 2024
georgeboc pushed a commit to georgeboc/aws-application-signals-test-framework that referenced this pull request Jul 8, 2024
…y#44)

This PR Instrument the sample application using CWOperator by setting up
following:
1. annotation: instrumentation.opentelemetry.io/inject-python: "true"
2. run the server with `--noreload`
3. Add `DJANGO_SETTINGS_MODULE` env variable.
4. Add `PYTHONPATH` env variable, this is required as CWOperator
instrumentation when application is mount in a specific directory
instead of root.
5. Add `OTEL_TRACES_SAMPLER`, this will be removed when Xray remote
sampler is ready.

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants