Support Python E2E test remote call from main build #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we also test if the python-canary workflow runs properly with this change? |
Sure, tested and updated in the PR overview. |
harrryr
approved these changes
Apr 23, 2024
zzhlogin
added a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…y#47) * Support Python E2E test remote call from main build
zzhlogin
added a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…y#47) * Support Python E2E test remote call from main build
zzhlogin
added a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…y#47) * Support Python E2E test remote call from main build
zzhlogin
added a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…y#47) * Support Python E2E test remote call from main build
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
…g Logic (aws-observability#47) *Issue #, if available:* Second PR of 3 parts for adding the X-Ray remote sampling support for OTel Python SDK. [See Part 1](aws-observability/aws-otel-python-instrumentation#33) *Description of changes:* - Sampling `RuleCache` - Caches a list of `Rule`s, ordered by rule priority then rule name. Each rule corresponds to the Sampling Rule from GetSamplingRules. Each call to GetSamplingRules will only update the `Rule`s that have changed properties, to preserve the state of unchanged rules. This means when Reservoir and Statistics are implemented in the `Rule`s, they will persist for unchanged rules. - The RuleCache will determine which Rule a set of {ResourceAttributes,SpanAttributes} matches with that has highest priority. - `Rule` - Corresponds to a `SamplingRule` and has logic to match with provided set of ResourceAttribute and SpanAttribute using the `Matcher` class. - Will determine the final sampling decision - `Matcher` class with methods to perform: - Convert X-Ray sampling rule options to regex patterns - Wild card and attribute matching - Initial class for `FallbackSampler` Testing: Unit tests By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Support Python E2E test remote call from main build in aws-otel-python-instrumentation
Test workflow:
main build: https://github.com/aws-observability/aws-otel-python-instrumentation/actions/runs/8804702307
python EC2 canary: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8805912573
python EKS canary: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8806000543
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.