E2E metric limiter #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrryr
force-pushed
the
e2e-metric-limiter
branch
from
dc4a949 to
ab150fe
Compare
bjrara
approved these changes
Apr 25, 2024
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…tric-limiter E2E metric limiter
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…tric-limiter E2E metric limiter
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…tric-limiter E2E metric limiter
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…tric-limiter E2E metric limiter
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
…observability#51) In this commit, we are removing the `set_http_status` logic from AwsMetricAttributeGenerator. This logic was originally in place for parity with Java. In Java, the OTEL instrumentation for AWS SDK does not populate the `http.status_code` attribute for spans, so we had to add logic to extract status code from the exception embedded within the events of the span. However, in Python, we have verified that this is not a problem; `http.status_code` is reliably set and so we do not need this logic. `set_http_status` logic is no longer needed, so this commit seeks to clean up the code by removing it and all code depending on it. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
We want to run an E2E canary to check if the metric limiter is appropriately labeling metrics as
AllOtherOperationsandAllOtherRemoteOperationswhen the number of service operation reach a certain thresholdDescription of changes:
/GETand/ERRORAPI to meet the thresholdAllOtherOperationsandAllOtherRemoteOperationsrespectively-Test run with metric threshold 2: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8832988258
Test run with metric threshold 4 (Should fail): https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8832746310/job/24250643113
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.