Update Metric Limiter Workflow Name and Add to All Region #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzhlogin
approved these changes
Apr 26, 2024
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…-metric-limiter-test Update Metric Limiter Workflow Name and Add to All Region
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…-metric-limiter-test Update Metric Limiter Workflow Name and Add to All Region
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…-metric-limiter-test Update Metric Limiter Workflow Name and Add to All Region
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…-metric-limiter-test Update Metric Limiter Workflow Name and Add to All Region
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
…y#54) In this PR, we are adding contract test runs to the pr-build and main-build, following suit with ADOT Java's [pr-build](https://github.com/aws-observability/aws-otel-java-instrumentation/blob/61460af22255d5963df17c77a37ef71ff6f652d8/.github/workflows/pr-build.yml#L90) and [main-build](https://github.com/aws-observability/aws-otel-java-instrumentation/blob/61460af22255d5963df17c77a37ef71ff6f652d8/.github/workflows/main-build.yml#L184). Like in Java, we are running these steps after building and pushing artifacts so we can debug more effectively, if needed. Unlike Java, we are not separating into separate jobs, as there is no clear benefit to doing this, as it just incurs overhead of checking out and building code. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update the metric limiter canary to run in all regions and also make minor fix/updates
Test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8854708923/job/24318314234
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.