Remove amazon-cloudwatch delete and call APIs before remote sample app #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majanjua-amzn
approved these changes
Apr 29, 2024
|
I believe |
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…tric-limiter Remove amazon-cloudwatch delete and call APIs before remote sample app
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…tric-limiter Remove amazon-cloudwatch delete and call APIs before remote sample app
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…tric-limiter Remove amazon-cloudwatch delete and call APIs before remote sample app
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…tric-limiter Remove amazon-cloudwatch delete and call APIs before remote sample app
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
*Issue #, if available:*
1. change tox.ini `py3{7,8,9,10,11}` to `3.{7,8,9,10,11}` so that the
workflow can run unit test.
2. change project Dokerfile to use python 3.10, because we are using
opentelemetry-exporter-otlp-proto-grpc, it use grpcio as dependencies.
It seems like grpc has a strict dependency on the OS / Python version.
Also mentioned in [Docker build template in
upstream](https://github.com/open-telemetry/opentelemetry-operator/blob/b5bb0ae34720d4be2d229dafecb87b61b37699b0/autoinstrumentation/python/requirements.txt#L2).
When we use python 3.11 to build the docker file, we receive `"Cannot
import name 'cygrpc' from 'grpc._cython'"` in EKS auto-instrumentation
injection. As
[https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/azure-functions/recover-python-functions.md#the-python-interpre[…]tions-python-worker](https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/azure-functions/recover-python-functions.md#the-python-interpreter-isnt-supported-by-azure-functions-python-workerr)
suggested, Azure Functions support python 3.6 - 3.9, but while testing,
3.10 also worked. So change to 3.10 here.
3. As we change the python version for Dockerfile we also change
main_build and release_build workflow to align with Dock build.
By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Metric limiter is having frequent failures due to two issues:
/healthcheckis called before the sample-app generates two APIs, causing the metric to have the actual value instead ofAllOtherRemoteOperation(Sample Link)Description of changes:
Test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8886143322
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.