Fix - Update metric limiter callingType for metric validation #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrryr
approved these changes
May 7, 2024
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…rename Fix - Update metric limiter callingType for metric validation
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…rename Fix - Update metric limiter callingType for metric validation
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…rename Fix - Update metric limiter callingType for metric validation
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…rename Fix - Update metric limiter callingType for metric validation
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
*Issue #, if available:* This PR implement _set_remote_target based on [Java implementation](https://github.com/aws-observability/aws-otel-java-instrumentation/blob/61460af22255d5963df17c77a37ef71ff6f652d8/awsagentprovider/src/main/java/software/amazon/opentelemetry/javaagent/providers/AwsMetricAttributeGenerator.java#L135). There is one difference between Java and python: Not like Java, AWS_#_NAME attributes are not supported in python as they are not part of the Semantic Conventions. We use Use `SpanAttributes` for `AWS_TABLE_NAME` and `AWS_BUCKET_NAME`. and manually add `AWS_QUEUE_URL`, `AWS_QUEUE_NAME` `AWS_STREAM_NAME`. This PR also fix a small bug in set_up/action.yml Testing, the code in this PR is tested by unit test. And also tested with local instrumentation by confirming the span attributes generated: ``` "net.peer.name": "dynamodb.us-east-1.amazonaws.com", "aws.dynamodb.table_names": [ "test_table" ], "aws.local.operation": "InternalOperation", "aws.request_id": "BL7KQGPQT88FCSRN3IM06LILRNVV4KQNSO5AEMVJF66Q9ASUAAJG", "retry_attempts": 0, "http.status_code": 200, "aws.local.service": "UnknownService", "aws.remote.service": "DynamoDB", "aws.remote.operation": "DescribeTable", "aws.remote.target": "::dynamodb:::table/test_table", "aws.span.kind": "LOCAL_ROOT" ``` By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8990477656/job/24695891452
Description of changes:
Update validator callingType that is required after #41
http-with-body->http-with-queryBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.