Skip to content

Update release_build.yml to reorder image releases #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Conversation

AsakerMohd
Copy link
Contributor

@AsakerMohd AsakerMohd commented Apr 9, 2024

Issue #, if available:

Description of changes:
Reordering the release steps in release_build.yml.

  • The old order is Public and Private ECR -> PyPI -> GitHub
  • The new order is PyPI -> Public ECR -> GitHub -> Private ECR.

Testing

Tested by creating a fork of this repo and running the release workflow. Changed the repos to my own private/public ECR repos and the images were published successfully as well as a draft release was created. One thing to callout, I removed the PyPI step as this step wasn't changed and I didn't see a reason to test publishing there.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AsakerMohd AsakerMohd requested a review from a team April 9, 2024 22:45
@AsakerMohd AsakerMohd requested a review from a team as a code owner April 11, 2024 23:26
@thpierce thpierce merged commit 5daac75 into main Apr 12, 2024
@thpierce thpierce deleted the AsakerMohd-patch-1 branch April 12, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants