Skip to content

Use Application Signals wherever possible #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Use Application Signals wherever possible #149

merged 2 commits into from
Apr 11, 2024

Conversation

thpierce
Copy link
Contributor

In this commit, we are changing appsignals, app_signals, app_signals, and app signals to applicationsignals, application_signals, application-signals, and application signals wherever possible. Callout aws-application-signals-team was created here: https://github.com/orgs/aws-observability/teams/aws-application-signals-team and has correct permissions on this repo.

Remaining usages:

  • aws_opentelemetry_configurator.py - we have to support both old and new config names (e.g. OTEL_AWS_APP_SIGNALS_ENABLED and OTEL_AWS_APPLICATION_SIGNALS_ENABLED)
  • application-signals-python-e2e-eks-test.yml, application-signals-python-e2e-ec2-test.yml, appsignals-python-e2e-eks-canary-test.yml, and appsignals-python-e2e-ec2-canary-test.yml - various reasons:
    • We rely on appsignals referenced in other repos that need to be updated first.
    • We emit metrics containing appsignals, which we have alarms on - changing is non-trivial.
    • Workflow names and urls contain appsignals - changing would break links (including runbooks).
    • We are depending on github secrets that are named appsignals
> grep -ir 'app_sig' .                                                           
./aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py:APP_SIGNALS_ENABLED_CONFIG = "OTEL_AWS_APP_SIGNALS_ENABLED"
./aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py:APP_SIGNALS_EXPORTER_ENDPOINT_CONFIG = "OTEL_AWS_APP_SIGNALS_EXPORTER_ENDPOINT"
./aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py:        os.environ.get(APPLICATION_SIGNALS_ENABLED_CONFIG, os.environ.get(APP_SIGNALS_ENABLED_CONFIG, "false")).lower()
./aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py:            os.environ.get(APP_SIGNALS_EXPORTER_ENDPOINT_CONFIG, "http://localhost:4315"),
./.github/workflows/application-signals-python-e2e-eks-test.yml:              -var="python_app_image=${{ env.ACCOUNT_ID }}.dkr.ecr.${{ inputs.aws-region }}.amazonaws.com/${{ secrets.APP_SIGNALS_PYTHON_E2E_FE_SA_IMG }}" \
./.github/workflows/application-signals-python-e2e-eks-test.yml:              -var="python_remote_app_image=${{ env.ACCOUNT_ID }}.dkr.ecr.${{ inputs.aws-region }}.amazonaws.com/${{ secrets.APP_SIGNALS_PYTHON_E2E_RE_SA_IMG }}" \
./.github/workflows/application-signals-python-e2e-eks-test.yml:                -var="python_app_image=${{ env.ACCOUNT_ID }}.dkr.ecr.${{ inputs.aws-region }}.amazonaws.com/${{ secrets.APP_SIGNALS_PYTHON_E2E_FE_SA_IMG }}" \
./.github/workflows/application-signals-python-e2e-eks-test.yml:                -var="python_remote_app_image=${{ env.ACCOUNT_ID }}.dkr.ecr.${{ inputs.aws-region }}.amazonaws.com/${{ secrets.APP_SIGNALS_PYTHON_E2E_RE_SA_IMG }}"
./.github/workflows/application-signals-python-e2e-eks-test.yml:            -var="python_app_image=${{ env.ACCOUNT_ID }}.dkr.ecr.${{ inputs.aws-region }}.amazonaws.com/${{ secrets.APP_SIGNALS_PYTHON_E2E_FE_SA_IMG }}" \
./.github/workflows/application-signals-python-e2e-eks-test.yml:            -var="python_remote_app_image=${{ env.ACCOUNT_ID }}.dkr.ecr.${{ inputs.aws-region }}.amazonaws.com/${{ secrets.APP_SIGNALS_PYTHON_E2E_RE_SA_IMG }}"
./.github/workflows/application-signals-python-e2e-ec2-test.yml:  TEST_ACCOUNT: ${{ secrets.APP_SIGNALS_E2E_TEST_ACC }}

> grep -ir 'app sig' .
./.github/workflows/appsignals-python-e2e-ec2-canary-test.yml:name: App Signals Enablement - Python E2E EC2 Canary Testing
./.github/workflows/appsignals-python-e2e-eks-canary-test.yml:name: App Signals Enablement - Python E2E EKS Canary Testing

> grep -ir 'appsig' . 
./.github/workflows/appsignals-python-e2e-ec2-canary-test.yml:      caller-workflow-name: 'appsignals-python-e2e-ec2-canary-test'
./.github/workflows/appsignals-python-e2e-eks-canary-test.yml:      caller-workflow-name: 'appsignals-python-e2e-eks-canary-test'
./.github/workflows/application-signals-python-e2e-eks-test.yml:  METRIC_NAMESPACE: AppSignals
./.github/workflows/application-signals-python-e2e-eks-test.yml:  LOG_GROUP_NAME: /aws/appsignals/eks
./.github/workflows/application-signals-python-e2e-eks-test.yml:          command: "wget https://raw.githubusercontent.com/aws-observability/application-signals-demo/main/scripts/eks/appsignals/enable-app-signals.sh 
./.github/workflows/application-signals-python-e2e-eks-test.yml:          && wget https://raw.githubusercontent.com/aws-observability/application-signals-demo/main/scripts/eks/appsignals/clean-app-signals.sh"
./.github/workflows/application-signals-python-e2e-ec2-test.yml:  METRIC_NAMESPACE: AppSignals
./.github/workflows/application-signals-python-e2e-ec2-test.yml:  LOG_GROUP_NAME: /aws/appsignals/generic

> grep -ir 'app-sig' .                                     
./.github/workflows/application-signals-python-e2e-eks-test.yml:          command: "wget https://raw.githubusercontent.com/aws-observability/application-signals-demo/main/scripts/eks/appsignals/enable-app-signals.sh 
./.github/workflows/application-signals-python-e2e-eks-test.yml:          && wget https://raw.githubusercontent.com/aws-observability/application-signals-demo/main/scripts/eks/appsignals/clean-app-signals.sh"
./.github/workflows/application-signals-python-e2e-eks-test.yml:          cleanup: "rm -f enable-app-signals.sh && rm -f clean-app-signals.sh"
./.github/workflows/application-signals-python-e2e-eks-test.yml:          post-command: "chmod +x enable-app-signals.sh && chmod +x clean-app-signals.sh"
./.github/workflows/application-signals-python-e2e-eks-test.yml:          sed -i "s#$delete_log_group##g" clean-app-signals.sh
./.github/workflows/application-signals-python-e2e-eks-test.yml:              "${GITHUB_WORKSPACE}/enablement-script/enable-app-signals.sh \
./.github/workflows/application-signals-python-e2e-eks-test.yml:              "${GITHUB_WORKSPACE}/enablement-script/clean-app-signals.sh \
./.github/workflows/application-signals-python-e2e-eks-test.yml:              ${GITHUB_WORKSPACE}/enablement-script/clean-app-signals.sh \
./.github/workflows/application-signals-python-e2e-eks-test.yml:              # Running clean-app-signal.sh removes the current cluster from the config. Update the cluster again for subsequent runs.
./.github/workflows/application-signals-python-e2e-eks-test.yml:          ./clean-app-signals.sh \

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thpierce thpierce requested a review from a team April 10, 2024 21:53
@thpierce thpierce merged commit 146af7e into main Apr 11, 2024
@thpierce thpierce deleted the sanitize branch April 11, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants