Skip to content

Add a microservices based sample app to test enablement #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jan 24, 2024

Conversation

AsakerMohd
Copy link
Contributor

Adding a microservices based sample app to help us test enablement for the python integration. Most of the code is boiler plate code created by Django.
The most important code to look at is inside the MainService folder for each microservice. Those are under the urls.py, views.py and the models.py.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AsakerMohd AsakerMohd requested a review from a team January 12, 2024 19:41
@thpierce
Copy link
Contributor

Most of the code is boiler plate code created by Django.

Can you be more specific:

  • What commands did you use to generate code?
  • What files were generated?
  • What files did you modify?

@AsakerMohd
Copy link
Contributor Author

Most of the code is boiler plate code created by Django.

Can you be more specific:

* What commands did you use to generate code?

* What files were generated?

* What files did you modify?

Starting a Django project using intellij generates the files. Intellij runs django-admin startproject <project_name> under the hood.

All the files were generated except docker specific files and my.cnf which is mysql config file for django web server to connect to the DB.

The files that were modified are under the MainService folder for each microservice. The specific files are urls.py, views.py and the models.py.

Copy link
Contributor

@thpierce thpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to review the urls.py and views.py files.

Copy link
Contributor

@zzhlogin zzhlogin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all code files, I think we need to add a header:

# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.

Since you are adding new folders, you should setup eachdist.py and eachdist.ini, to allow lint and test workflow apply to all files/tests.

@AsakerMohd AsakerMohd merged commit dc1c3ca into main Jan 24, 2024
@AsakerMohd AsakerMohd deleted the pythonSampleApp branch January 24, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants