Skip to content

Fix deep copy related issue #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 7, 2024
Merged

Fix deep copy related issue #46

merged 8 commits into from
Feb 7, 2024

Conversation

XinRanZhAWS
Copy link
Contributor

Description of changes:
Remove deepcopy for span to avoid issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@XinRanZhAWS XinRanZhAWS requested a review from a team February 7, 2024 17:49
Copy link
Contributor

@thpierce thpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw in the test_aws_metric_attributes_span_exporter.py unit tests that we have a bunch of deepcopy logic, e.g. _build_readable_span_mock_without_deepcopy_support. Should/can we remove that to reduce confusion in the code and improve parity with java code?

@XinRanZhAWS XinRanZhAWS merged commit 4547c02 into main Feb 7, 2024
@XinRanZhAWS XinRanZhAWS deleted the fix_deepcopy branch February 7, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants