Run contract tests in pr- and main- build workflows #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzhlogin
reviewed
Feb 13, 2024
zzhlogin
reviewed
Feb 13, 2024
zzhlogin
reviewed
Feb 13, 2024
zzhlogin
reviewed
Feb 13, 2024
zzhlogin
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we are adding contract test runs to the pr-build and main-build, following suit with ADOT Java's pr-build and main-build. Like in Java, we are running these steps after building and pushing artifacts so we can debug more effectively, if needed. Unlike Java, we are not separating into separate jobs, as there is no clear benefit to doing this, as it just incurs overhead of checking out and building code.
Testing was done by forcing runs on pushes to
contract-tests-workflow:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.