-
Notifications
You must be signed in to change notification settings - Fork 22
Added new python profiler for performance testing #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpierce
reviewed
Mar 1, 2024
performance-tests/src/test/java/io/opentelemetry/results/CsvPersister.java
Show resolved
Hide resolved
performance-tests/src/test/java/io/opentelemetry/results/PrintStreamPersister.java
Outdated
Show resolved
Hide resolved
sample-applications/vehicle-dealership-sample-app/VehicleInventoryApp/requirements.txt
Outdated
Show resolved
Hide resolved
thpierce
reviewed
Mar 4, 2024
performance-tests/src/test/java/io/opentelemetry/results/ResultsCollector.java
Outdated
Show resolved
Hide resolved
performance-tests/src/test/java/io/opentelemetry/util/NamingConvention.java
Outdated
Show resolved
Hide resolved
performance-tests/src/test/java/io/opentelemetry/util/ProfilerUtils.java
Outdated
Show resolved
Hide resolved
performance-tests/src/test/java/io/opentelemetry/util/ProfilerUtils.java
Outdated
Show resolved
Hide resolved
thpierce
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added a new profiler.py script that uses psutils to get per process info such as Network Bytes Sent/Received, CPU, Resident Memory (Phyical RAM used), virtual memory and the peak number of threads. Updated the persisters as well to read the new data and populate
summary.txt
andresults.csv
as expected. Below is an example from a test run.Also added a bunch of TODO comments to clean up old JFR logic that is no longer required here and to keep this PR changes to a minimum.
Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.