Skip to content

Refined release workflow #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 6, 2024
Merged

Refined release workflow #97

merged 6 commits into from
Mar 6, 2024

Conversation

srprash
Copy link
Contributor

@srprash srprash commented Mar 5, 2024

The workflow will be tested soon and modifications will be made if required from the test.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srprash srprash requested a review from a team March 5, 2024 22:31
Copy link
Contributor

@thpierce thpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do any kind of test of this? Even just commenting out public update steps and running that?

@srprash
Copy link
Contributor Author

srprash commented Mar 6, 2024

Can we do any kind of test of this? Even just commenting out public update steps and running that?

Yea. I think we can do the following:

  1. Merge the PR with steps to publish to prod PyPI and ECR repos commented out
  2. Run the workflow with input version as 0.0.0 to ensure we are able to build, authenticate, and push to testPyPI successfully.
  3. Uncomment the steps in a follow-up PR. And then run the workflow for v 0.0.1 release.

@srprash
Copy link
Contributor Author

srprash commented Mar 6, 2024

Ok. So as discussed, I commented the prod publishing steps and tested the workflow: https://github.com/aws-observability/aws-otel-python-instrumentation/actions/runs/8177260016
The wheel was published to TestPyPI: https://test.pypi.org/project/aws-opentelemetry-distro/0.0.0/

I will revert the test changes and make the PR ready for review.

@srprash srprash merged commit a6ab668 into main Mar 6, 2024
@srprash srprash deleted the release-wf branch March 6, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants