Skip to content

chore: Sync main with develop #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 10, 2024
Merged

chore: Sync main with develop #566

merged 20 commits into from
Mar 10, 2024

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Mar 10, 2024

Please provide the issue number

Issue number: #563

Summary

Sync branch

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig March 10, 2024 17:44
@boring-cyborg boring-cyborg bot added area/idempotency area/parameters area/tracing Core tracing utility documentation Improvements or additions to documentation tests labels Mar 10, 2024
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 10, 2024
@github-actions github-actions bot added the internal Maintenance changes label Mar 10, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.6% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 59.94695% with 151 lines in your changes are missing coverage. Please review.

Project coverage is 72.37%. Comparing base (6286cad) to head (9148d02).
Report is 37 commits behind head on main.

Files Patch % Lines
...wertools.Parameters/AppConfig/AppConfigProvider.cs 58.85% 73 Missing and 6 partials ⚠️
...rnal/AppConfig/AppConfigJsonConfigurationParser.cs 53.22% 27 Missing and 2 partials ⚠️
...AppConfig/AppConfigProviderConfigurationBuilder.cs 73.91% 14 Missing and 4 partials ⚠️
....Lambda.Powertools.Parameters/ParametersManager.cs 0.00% 15 Missing ⚠️
...ternal/AppConfig/AppConfigDictionaryTransformer.cs 53.84% 3 Missing and 3 partials ⚠️
...s/Internal/AppConfig/AppConfigFeatureFlagHelper.cs 63.63% 2 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
- Coverage   74.10%   72.37%   -1.73%     
==========================================
  Files         101      109       +8     
  Lines        4112     4489     +377     
  Branches      418      455      +37     
==========================================
+ Hits         3047     3249     +202     
- Misses        951     1106     +155     
- Partials      114      134      +20     
Flag Coverage Δ
unittests 72.37% <59.94%> (-1.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjgraca hjgraca merged commit 97a49e0 into main Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/idempotency area/parameters area/tracing Core tracing utility documentation Improvements or additions to documentation internal Maintenance changes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants