Arpin uncomment delete #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winstonaws
reviewed
Dec 4, 2017
| "#sage.delete_endpoint(EndpointName=endpoint_name)\n", | ||
| "#sage.delete_model(ModelName=model_name)" | ||
| "sage.delete_endpoint(EndpointName=endpoint_name)\n", | ||
| "sage.delete_model(ModelName=model_name)" |
| "#sage.delete_endpoint(EndpointName=endpoint_name)\n", | ||
| "#sage.delete_model(ModelName=model_name)" | ||
| "sage.delete_endpoint(EndpointName=endpoint_name)\n", | ||
| "sage.delete_model(ModelName=model_name)" |
There was a problem hiding this comment.
None of the other notebooks delete the model, so should we remove this?
| @@ -209,7 +209,7 @@ | |||
| }, | |||
| "outputs": [], | |||
| "source": [ | |||
| "# m.delete_endpoint()" | |||
| "m.delete_endpoint()" | |||
There was a problem hiding this comment.
I don't think we want to keep this method on the estimator longer term. Can you change this to use the session to delete it?
winstonaws
approved these changes
Dec 4, 2017
ajaykarpur
pushed a commit
that referenced
this pull request
Dec 8, 2020
* update file pattern * drop empty line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've decided to uncomment out endpoint deletion as a best practice for examples.