Skip to content

Update xgboost_direct_marketing_sagemaker.ipynb #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update xgboost_direct_marketing_sagemaker.ipynb #159

wants to merge 1 commit into from

Conversation

roachmd
Copy link

@roachmd roachmd commented Jan 8, 2018

I was getting an error with this line in conda_python3 :: hist = data.hist(bins=30, sharey=True, figsize=(10, 10))
I updated it to read hist = data.hist(30, True, figsize(10, 10))

I was getting an error with this line in conda_python3 :: hist = data.hist(bins=30, sharey=True, figsize=(10, 10))
I updated it to read hist = data.hist(30, True, figsize(10, 10))
Copy link
Contributor

@djarpin djarpin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interest in this Amazon SageMaker example notebook!

Were you running this code from a SageMaker Notebook Instance or your own laptop/desktop/EC2 instance? The existing code runs successfully from a fresh SageMaker Notebook Instance. I'm wondering if this is an issue caused by running a different version of Pandas (SageMaker Notebook's version is 0.20.3). Can you confirm which version of Pandas you're running?

The code you've updated to doesn't appear to run for me, giving an error of:

name 'figsize' is not defined

Even when adjusted to:

hist = data.hist(30, True, figsize=(10, 10))

I still receive a KeyError as according to the documentation Pandas appears to be looking for "column" as the second positional argument, which doesn't accept a boolean as input.

@roachmd
Copy link
Author

roachmd commented Jan 9, 2018

Running this in a new sagemaker notebook.
pd.version
0.20.3

That line I get "SyntaxError: positional argument follow keyword argument"

Now I just remove and retyped the line. Seems fine now. So, disreguard ;-)

@roachmd roachmd closed this Jan 9, 2018
atqy pushed a commit to atqy/amazon-sagemaker-examples that referenced this pull request Aug 16, 2022
* Fixes issue: awslabs/sagemaker-debugger#113 
* bug fix in tensor_names. won't include extra reduction names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants