Skip to content

Fixed malformed TensorFlow estimator declaration. #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Nov 11, 2020
Merged

Fixed malformed TensorFlow estimator declaration. #1628

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba0d56f
Fixed malformed TensorFlow estimator declaration.
pccornel Oct 16, 2020
09c2338
Removed extraneous output.
pccornel Oct 16, 2020
6925931
Merge branch 'master' into pccornel-tensorflow_mnist
metrizable Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions aws_sagemaker_studio/frameworks/tensorflow_mnist/tensorflow_mnist.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,10 @@
"\n",
"estimator = TensorFlow(entry_point=training_script,\n",
" role=role,\n",
" train_instance_count=1,\n",
" train_instance_type='ml.p2.xlarge',\n",
" instance_count=1,\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a v1 --> v2 update?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a v1 --> v2 update.

" instance_type='ml.p2.xlarge',\n",
" framework_version=tf_version,\n",
" py_version='py3',\n",
" distributions={'parameter_server': {'enabled': True}})"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense that you don't need this with one node, but was this breaking something?
Can you put in the PR description which issue this fixes?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of any specific issues in GitHub that this fixes.

" py_version='py3')"
]
},
{
Expand Down Expand Up @@ -259,14 +258,21 @@
"source": [
"predictor.delete_endpoint()"
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": []
}
],
"metadata": {
"instance_type": "ml.t3.medium",
"kernelspec": {
"display_name": "Python 3 (Data Science)",
"language": "python",
"name": "python3__SAGEMAKER_INTERNAL__arn:aws:sagemaker:us-east-2:429704687514:image/datascience-1.0"
"name": "python3__SAGEMAKER_INTERNAL__arn:aws:sagemaker:us-east-1:081325390199:image/datascience-1.0"
},
"language_info": {
"codemirror_mode": {
Expand Down