Skip to content

avoid issuing more than one stop job requests #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2020
Merged

avoid issuing more than one stop job requests #1791

merged 1 commit into from
Nov 25, 2020

Conversation

gilinachum
Copy link
Contributor

Description of changes:

  • avoid issuing more than one stop job requests (stop only if job status is InProgress).
  • fix logging to write to lambda logs
  • ask user to configure a 30sec timeout instead of 3sec (saw it timing out).
  • Improve logging info

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

- avoid issuing more than one stop job requests (stop only if job status is InProgress).
- fix logging to write to lambda logs
- ask user to configure a 30sec timeout instead of 3sec (saw it timing out).
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-examples-processing
  • Commit ID: e460c86
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: amazon-sagemaker-examples-pr
  • Commit ID: e460c86
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aaronmarkham aaronmarkham merged commit aa22e25 into aws:master Nov 25, 2020
gilinachum added a commit to gilinachum/amazon-sagemaker-developer-guide that referenced this pull request Nov 26, 2020
@gilinachum
Copy link
Contributor Author

Created a matching PR for the lambda code in the official doc pages: awsdocs/amazon-sagemaker-developer-guide#99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants