26-Nov: Fixes to Issue #1800 and SDKv2 corrections #1801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description of Changes 1- Solution to aws#1800 to call serializer in the Predictor constructor 2-SDKv2 updates incorporated (renamed RealTimePredictor, removed content_type from Predictor constructor, renamed image_name in estimator call etc.) 3-Changed inference instance type to m5.large (newer generation, less cost) ## Test Scenario Tested in SageMaker Studio (but with Sagemaker Classic Notebook option) SageMaker SDK version = 2.16.3.post0 See completed notebook here: https://github.com/CloudaYolla/fastai-study-group-DL4coders/blob/main/zoo-smaker-nb/DeepAR-Electricity-StudioNI-PA4.ipynb
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aaronmarkham
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
1- Solution to #1800 to call serializer in the Predictor constructor
2-SDKv2 updates incorporated (renamed RealTimePredictor, removed content_type from Predictor constructor, renamed image_name in estimator call etc.)
3-Changed inference instance type to m5.large (newer generation, less cost)
Test Scenario
Tested in SageMaker Studio (but with Sagemaker Classic Notebook option)
SageMaker SDK version = 2.16.3.post0
See completed notebook here: https://github.com/CloudaYolla/fastai-study-group-DL4coders/blob/main/zoo-smaker-nb/DeepAR-Electricity-StudioNI-PA4.ipynb
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.