Updated xgboost_customer_churn.ipynb for SageMaker SDK v2 #1803
Conversation
Notebook needed updates to be compatible with the v2 of the SageMaker SDK, which is the new Default SDK version in SageMaker.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -49,7 +49,6 @@ | |||
| "cell_type": "code", | |||
There was a problem hiding this comment.
please remove the old import of SDK V1. also if you can, pls move all the imports in the beginning cells itself.
Reply via ReviewNB
| @@ -49,7 +49,6 @@ | |||
| "cell_type": "code", | |||
There was a problem hiding this comment.
add an import for sagemaker.inputs.TrainingInput
from sagemaker.inputs import TrainingInput
Reply via ReviewNB
| @@ -49,7 +49,6 @@ | |||
| "cell_type": "code", | |||
There was a problem hiding this comment.
why neo support code is removed? is Neo available in all AWS regions now?
also, please change the get_image_uri to the latest SDK v2 contract.
Reply via ReviewNB
| @@ -49,7 +49,6 @@ | |||
| "cell_type": "code", | |||
There was a problem hiding this comment.
can you pls use a direct reference to CSVSerializer instead of using fully qualified import? just makes the code bit cleaner.
Reply via ReviewNB
1. Remove the old import of SDK V1. 2. Added imports for TrainingInput and CSVSerializer to keep code cleaner. 3. The check_neo_region was removed since it is not supported in SDK v2, and from Sep 26, 2019, Amazon SageMaker Neo is Available in 12 additional Regions. 5. get_image_uri in Neo compilation was removed since it is not needed at all. 5. Moved the print of cutoffs, and costs to a diffferent cell since it used to throw an error on the first run.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@aaronmarkham |
Notebook needed updates to be compatible with the v2 of the SageMaker SDK, which is the new Default SDK version in SageMaker.
Issue #, if available:
Description of changes:
Notebook needed updates to be compatible with the v2 of the SageMaker SDK, which is the new Default SDK version in SageMaker.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.