-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Add Mxnet MNIST example #1888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mxnet MNIST example #1888
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
raise | ||
|
||
# untar the model | ||
tar = tarfile.open(os.path.join(model_dir, 'model.tar.gz')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
Analysis of this code determined that this line of code contains a resource that might not have closed properly. Although there is an explicit call to close()
, some execution paths do not reach it, such as in case of an exception. A resource leak can slow down or crash your system. Programs are strongly recommended to use the built in with
keyword to open a resource or to use a try-finally
block to open and close resources explicitly. The contextlib module provides helpful utilities for using the with
statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.