Fixed: validation file name in upload to S3 #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atqy
pushed a commit
to atqy/amazon-sagemaker-examples
that referenced
this pull request
Aug 16, 2022
* Implement common hooks in core * combine abstract and static methods * rename method * fix variable name * fix test * fix test * Fix loss decreasing test * remove data * Reduce length of tests, also removed unnecessary s3 test * Fix test * Delete test.py * Address review by Edward * Call super constructor immediately * Reduce logging in CI and fix tests * Fix bug and reduce verbosity in CI * Trying out CI with loss test disabled * Update hook.py * Disable unreliable test * use new collection file name * fix args for method * create coll by default * fix pytorch tests * Add xgboost tests * remove exception catching * remove extra import * Fix all names of collections to use CollectionKeys, and create collection in a safe way for when json parser creates collections * Cleanup * Rename input, and add xgboost to CI evn * fix bug of tuple name of dict * Add couple of docstrings * Address renamed cleanup method * Rename bias to biases * cleanup removal of dir code * Remove save manager * docs for loss not decreasing * rename reduction method * pass out dir to test * fix test * use coll manager to add tensors * change a loop and some imports
atqy
pushed a commit
to atqy/amazon-sagemaker-examples
that referenced
this pull request
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.