Skip to content

Added: Gluon recommender system notebook #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2018
Merged

Added: Gluon recommender system notebook #218

merged 2 commits into from
Mar 30, 2018

Conversation

djarpin
Copy link
Contributor

@djarpin djarpin commented Mar 25, 2018

No description provided.

@djarpin djarpin requested a review from cswiercz March 25, 2018 06:15
@djarpin djarpin mentioned this pull request Mar 25, 2018
Closed
@djarpin djarpin requested review from ragavvenkatesan and removed request for cswiercz March 26, 2018 17:00
@orchidmajumder
Copy link
Contributor

I can review notebooks written in Gluon. I'll take this review on myself.

@orchidmajumder
Copy link
Contributor

@djarpin could you please add me to the reviewers?

@djarpin djarpin requested a review from orchidmajumder March 29, 2018 20:51
@djarpin
Copy link
Contributor Author

djarpin commented Mar 29, 2018

Thanks @orchidmajumder . I've added you as a reviewer.

orchidmajumder
orchidmajumder reviewed Mar 30, 2018
View reviewed changes
introduction_to_applying_machine_learning/gluon_recommender_system/recommender.py Outdated
self.dropout = gluon.nn.Dropout(dropout_p)
self.dense = gluon.nn.Dense(num_emb, activation='relu')

def forward(self, users, items):
Copy link
Contributor

@orchidmajumder orchidmajumder Mar 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use hybrid_forward. The operation here is simple and should be easily hybridized. And then use net.hybridize() before starting the training.

orchidmajumder
orchidmajumder reviewed Mar 30, 2018
View reviewed changes
introduction_to_applying_machine_learning/gluon_recommender_system/recommender.py Outdated
with mx.autograd.record():
output = net(user, item)
loss = loss_function(output, label)
loss.backward()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: loss.backward() does not need to be within autograd block.

orchidmajumder
orchidmajumder reviewed Mar 30, 2018
View reviewed changes
introduction_to_applying_machine_learning/gluon_recommender_system/recommender.py Outdated
output = net(user, item)
loss = loss_function(output, label)
loss.backward()
net.collect_params().values()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems redundant.

orchidmajumder
orchidmajumder approved these changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@orchidmajumder orchidmajumder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please take care of the network hybridization before pushing to the main repo.

@djarpin
Copy link
Contributor Author

djarpin commented Mar 30, 2018

Thanks @orchidmajumder ! Updates and fixes made.

@djarpin djarpin merged commit b69ab53 into master Mar 30, 2018
@djarpin djarpin deleted the arpin_gluon_recsys branch April 10, 2018 15:03
atqy pushed a commit to atqy/amazon-sagemaker-examples that referenced this pull request Aug 16, 2022
@jarednielsen @rahul003
Flattened JSON config format (aws#218)
ebb6bae 
* Flatten the JSON configuration format. See https://quip-amazon.com/ja7nAmXMVE5p for details.
I rewrote the JSON for all the tests and ran them to ensure they still pass.

* Flatten the JSON configuration format. See https://quip-amazon.com/ja7nAmXMVE5p for details.
I rewrote the JSON for all the tests and ran them to ensure they still pass.

* Undo formatting.

* Undo formatting more

* Fix typo that got reverted with the formatting revert

* Fix JSON typo

* Address Rahul's refactoring comments

* Ensure we default to global mode if no specific train/eval/predict setting

* Update .gitignore

* Rewrite the logic for handling defaults. CollectionParameters default to HookParameters, and HookParameters default to the defaults.

* Added test for merging logic

* Fix failing test

* Remove trailing comma in JSON
atqy pushed a commit to atqy/amazon-sagemaker-examples that referenced this pull request Aug 16, 2022
@NihalHarish
Save Optimizer Variables With Keras Fit API In Eager Mode (aws#218)
1053ee5
atqy pushed a commit to atqy/amazon-sagemaker-examples that referenced this pull request Nov 30, 2022
@billdoors @shreyapandit
shadow endpoint (aws#219)
7812ad3 
* initial commit

* minor fix

* minor fixes

* add inference experiment notebook

add inference experiment notebook

* Add shadow endpoint notebook (aws#215)

* initial commit

* add inference experiment notebook

add inference experiment notebook

Co-authored-by: Qingwei Li<[email protected]>
Co-authored-by: Shreya Pandit <[email protected]>
Co-authored-by: Qingwei Li <[email protected]>

* Revert "Add shadow endpoint notebook (aws#215)" (aws#218)

This reverts commit b6d2fd203f7f85670478556e902ad2bb86a1a882.

* reformat

* reviewer's comments addressed

* clear output

* fix and reformat nb

* reformat nb

* remove notebook

* markdown change

Co-authored-by: EC2 Default User <[email protected]>
Co-authored-by: Shreya Pandit <[email protected]>
Co-authored-by: Qingwei Li <[email protected]>
Co-authored-by: EC2 Default User <[email protected]>
atqy added a commit to atqy/amazon-sagemaker-examples that referenced this pull request Nov 30, 2022
@billdoors @shreyapandit @atqy
updated shadow_variants with Alwin's work (aws#225)
2215179 
* initial commit

* minor fix

* minor fixes

* add inference experiment notebook

add inference experiment notebook

* Add shadow endpoint notebook (aws#215)

* initial commit

* add inference experiment notebook

add inference experiment notebook

Co-authored-by: Qingwei Li<[email protected]>
Co-authored-by: Shreya Pandit <[email protected]>
Co-authored-by: Qingwei Li <[email protected]>

* Revert "Add shadow endpoint notebook (aws#215)" (aws#218)

This reverts commit b6d2fd203f7f85670478556e902ad2bb86a1a882.

* reformat

* reviewer's comments addressed

* clear output

* fix and reformat nb

* reformat nb

* remove notebook

* markdown change

* Alwin's edit

add edits from Alwin

* reformat

* change folder name

Co-authored-by: EC2 Default User <[email protected]>
Co-authored-by: Shreya Pandit <[email protected]>
Co-authored-by: Qingwei Li <[email protected]>
Co-authored-by: EC2 Default User <[email protected]>
Co-authored-by: atqy <[email protected]>
Co-authored-by: atqy <[email protected]>
atqy pushed a commit to atqy/amazon-sagemaker-examples that referenced this pull request Nov 30, 2022
@billdoors @shreyapandit @atqy
shadow endpoint (aws#219)
f841bb2 
* initial commit

* minor fix

* minor fixes

* add inference experiment notebook

add inference experiment notebook

* Add shadow endpoint notebook (aws#215)

* initial commit

* add inference experiment notebook

add inference experiment notebook

Co-authored-by: Qingwei Li<[email protected]>
Co-authored-by: Shreya Pandit <[email protected]>
Co-authored-by: Qingwei Li <[email protected]>

* Revert "Add shadow endpoint notebook (aws#215)" (aws#218)

This reverts commit b6d2fd203f7f85670478556e902ad2bb86a1a882.

* reformat

* reviewer's comments addressed

* clear output

* fix and reformat nb

* reformat nb

* remove notebook

* markdown change

Co-authored-by: EC2 Default User <[email protected]>
Co-authored-by: Shreya Pandit <[email protected]>
Co-authored-by: Qingwei Li <[email protected]>
Co-authored-by: EC2 Default User <[email protected]>
atqy added a commit to atqy/amazon-sagemaker-examples that referenced this pull request Nov 30, 2022
@billdoors @shreyapandit @atqy
updated shadow_variants with Alwin's work (aws#225)
7b724dc 
* initial commit

* minor fix

* minor fixes

* add inference experiment notebook

add inference experiment notebook

* Add shadow endpoint notebook (aws#215)

* initial commit

* add inference experiment notebook

add inference experiment notebook

Co-authored-by: Qingwei Li<[email protected]>
Co-authored-by: Shreya Pandit <[email protected]>
Co-authored-by: Qingwei Li <[email protected]>

* Revert "Add shadow endpoint notebook (aws#215)" (aws#218)

This reverts commit b6d2fd203f7f85670478556e902ad2bb86a1a882.

* reformat

* reviewer's comments addressed

* clear output

* fix and reformat nb

* reformat nb

* remove notebook

* markdown change

* Alwin's edit

add edits from Alwin

* reformat

* change folder name

Co-authored-by: EC2 Default User <[email protected]>
Co-authored-by: Shreya Pandit <[email protected]>
Co-authored-by: Qingwei Li <[email protected]>
Co-authored-by: EC2 Default User <[email protected]>
Co-authored-by: atqy <[email protected]>
Co-authored-by: atqy <[email protected]>
atqy added a commit that referenced this pull request Nov 30, 2022
@atqy @aberlm
@rodzanto @seanpmorgan @Zhenshan-Jin @billdoors @shreyapandit
Reinvent22 (#3686)
cf7012a 
* Adding example for native AutoML step in SageMaker Pipelines. (#211)

* Adding example for native AutoML step in SageMaker Pipelines.

* Adding SageMaker Geospatial example for Digital Farming (#213)

* Adding digital-farming-pipelines notebooks

* Adding digital-farming-pipelines notebooks

* Update pipelines-sagemaker-geospatial.ipynb

* Update pipelines-sagemaker-geospatial.ipynb

* Update pipelines-sagemaker-geospatial.ipynb

* Update pipelines-sagemaker-geospatial.ipynb

* Adding digital-farming-pipelines notebooks

* Adding digital-farming-pipelines notebooks

* Adding code folder

* Adding Lambda function

* Adjusting notebook

* Adjuting roles

* Adjusted roles

* Updated notebooks

* Updated notebooks format

* Adding Scheduled Notebook (Keynote2) (#216)

* * Add scheduled notebook example

* Update notebook

* Format

* Change image dir

* Resolve comments.

* Resolve comments.

* Resolve comments.

* Add example notebook for model governance model card (#217)

Co-authored-by: Zhenshan Jin <[email protected]>

* shadow endpoint (#219)

* initial commit

* minor fix

* minor fixes

* add inference experiment notebook

add inference experiment notebook

* Add shadow endpoint notebook (#215)

* initial commit

* add inference experiment notebook

add inference experiment notebook

Co-authored-by: Qingwei Li<[email protected]>
Co-authored-by: Shreya Pandit <[email protected]>
Co-authored-by: Qingwei Li <[email protected]>

* Revert "Add shadow endpoint notebook (#215)" (#218)

This reverts commit b6d2fd203f7f85670478556e902ad2bb86a1a882.

* reformat

* reviewer's comments addressed

* clear output

* fix and reformat nb

* reformat nb

* remove notebook

* markdown change

Co-authored-by: EC2 Default User <[email protected]>
Co-authored-by: Shreya Pandit <[email protected]>
Co-authored-by: Qingwei Li <[email protected]>
Co-authored-by: EC2 Default User <[email protected]>

* rename sagemaker-shadow-endpoint folder

* upgrade pip packages for reinvent

* install from reinvent wheels temporarily

* Keynote2 rtd (#224)

* remove --no-deps tags from notebook

* configure rst files for reinvent notebooks + fix any rtd leveling issues

* make corrections

* reformat

* updated shadow_variants with Alwin's work (#225)

* initial commit

* minor fix

* minor fixes

* add inference experiment notebook

add inference experiment notebook

* Add shadow endpoint notebook (#215)

* initial commit

* add inference experiment notebook

add inference experiment notebook

Co-authored-by: Qingwei Li<[email protected]>
Co-authored-by: Shreya Pandit <[email protected]>
Co-authored-by: Qingwei Li <[email protected]>

* Revert "Add shadow endpoint notebook (#215)" (#218)

This reverts commit b6d2fd203f7f85670478556e902ad2bb86a1a882.

* reformat

* reviewer's comments addressed

* clear output

* fix and reformat nb

* reformat nb

* remove notebook

* markdown change

* Alwin's edit

add edits from Alwin

* reformat

* change folder name

Co-authored-by: EC2 Default User <[email protected]>
Co-authored-by: Shreya Pandit <[email protected]>
Co-authored-by: Qingwei Li <[email protected]>
Co-authored-by: EC2 Default User <[email protected]>
Co-authored-by: atqy <[email protected]>
Co-authored-by: atqy <[email protected]>

* add region tag to allow download from opt-in regions (#226)

* add region tag to allow download from opt-in regions

* add region tag to allow download from opt-in regions

* Trigger Build

Co-authored-by: Marcelo Aberle <[email protected]>
Co-authored-by: Antonio Rodriguez <[email protected]>
Co-authored-by: Sean Morgan <[email protected]>
Co-authored-by: Zhenshan Jin <[email protected]>
Co-authored-by: Zhenshan Jin <[email protected]>
Co-authored-by: Qingwei Li <[email protected]>
Co-authored-by: EC2 Default User <[email protected]>
Co-authored-by: Shreya Pandit <[email protected]>
Co-authored-by: Qingwei Li <[email protected]>
Co-authored-by: EC2 Default User <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orchidmajumder orchidmajumder orchidmajumder approved these changes

@ragavvenkatesan ragavvenkatesan Awaiting requested review from ragavvenkatesan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djarpin @orchidmajumder