Update the helper function to cat is not Non #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, cat = 0 won't be written to the data file
djarpin
approved these changes
Apr 27, 2018
atqy
pushed a commit
to atqy/amazon-sagemaker-examples
that referenced
this pull request
Aug 16, 2022
* test * added missing import * get worker name from func * random seed: * str error * error handling * hvd-size * worker name to collection * removed unecessary comment * try catch for modulenotfound * simplified mkdir error handling * handle hvd.size ValueError * modify try except block * moving worker name to utils * worker to collections.ts * list collection files * checkpoint_1 * Mirrored Variable * mirrored var * revert accidental change * print statement cleanup * save json file * update num workers * s3 mode trial api * tests starting * fixed test trial modes * bug fix * removed randint generator * pytorch test fix * fixed bug in test * merge conflicts and tf tests * merge alpha to fix breaking tests * code cleanup * fixed get correct worker bug * fixed None not 0 bug * made worker name for hvd more verbose * fixed mode step bug * changed worker name parsing logic * missing line * removed hard coded worker_num values * paramterized collections name * changes for PR comments * PR changes * step variable rename and refactor * reverting 4eeb4d4 * refactored changes * read test * refactor changes * handle import error for pytorch * Handle Import Error * removed worker from hook, set default value to num_workers, addressed PR comments * doc string update * replace StepIsUnavailable with ValueError and fix return with raise
atqy
pushed a commit
to atqy/amazon-sagemaker-examples
that referenced
this pull request
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, cat = 0 won't be written to the data file