This repository was archived by the owner on Jul 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
Polish Helm charts #76
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
7a17d5c
Refactored helm charts to indent 2
RedbackThomson 00f5d24
Fixed resource release notes
RedbackThomson b3203dd
Refactored chart descriptions
RedbackThomson e8e45c2
Added missing casing fixes
RedbackThomson 5667646
Added tags to chart
RedbackThomson 1a7c365
Fixed chart names
RedbackThomson d306458
Added documentation in release notes
RedbackThomson 71a4557
Updated job spec notes
RedbackThomson 2c126ce
Added job dependencies on operator
RedbackThomson 20655f3
Comment out dependencies until deployed to EKS repo
RedbackThomson f010fa6
Incremented chart version to match api version
RedbackThomson b3aa4bc
Added helm 3 prerequisite
RedbackThomson a90d891
Merge branch 'master' into polish_helm
RedbackThomson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,13 @@ | ||
| apiVersion: v1 | ||
| name: sagemaker-k8s-trainingjob | ||
| version: 0.1.0 | ||
| description: A Helm chart for deploying the SageMaker Batch Transform Job for Kubernetes. | ||
| name: amazon-sagemaker-batchtransformjob | ||
| version: 1.0.0 | ||
| description: A Helm chart for deploying a SageMaker Batch Transform Job from Kubernetes. | ||
| maintainers: | ||
| - name: Gautam Kumar | ||
| email: [email protected] | ||
| - name: Cade Daniel | ||
| email: [email protected] | ||
| - name: Nicholas Thomson | ||
| email: [email protected] | ||
| - name: Meghna Baijal | ||
| email: [email protected] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,8 @@ | ||
| Thanks for installing the {{ .Chart.Name }}. | ||
| Successfully deployed a new batch transform job chart. | ||
|
|
||
| Your release is named {{ .Release.Name }}. | ||
|
|
||
| To learn more about the release, try: | ||
|
|
||
| $ helm status {{ .Release.Name }} | ||
| $ helm get {{ .Release.Name }} | ||
|
|
||
| To use the latest features, try adding attributes to yaml by generating it: | ||
|
|
||
| $ helm install <directory of charts> --debug --dry-run | ||
| $ helm get all {{ .Release.Name }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| name: xgboost-mnist-batch-transform | ||
| spec: | ||
| instancecount: 1 | ||
| instancetype: ml.m4.xlarge | ||
| region: us-west-2 | ||
| modelname: xgboost-mnist-model | ||
| inputdataconfig: | ||
| s3uri: s3://sagemaker-sample-data-us-west-2/batch-transform/mnist-1000-samples | ||
| s3datatype: S3Prefix | ||
| outputpath: s3://my-bucket/batch_transform/output | ||
| instanceCount: 1 | ||
| instanceType: ml.m4.xlarge | ||
| region: us-west-2 | ||
| modelName: xgboost-mnist-model | ||
| inputDataConfig: | ||
| s3Uri: s3://sagemaker-sample-data-us-west-2/batch-transform/mnist-1000-samples | ||
| s3DataType: S3Prefix | ||
| outputPath: s3://my-bucket/batch_transform/output | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,13 @@ | ||
| apiVersion: v1 | ||
| name: sagemaker-k8s-trainingjob | ||
| version: 0.1.0 | ||
| description: A Helm chart for deploying the SageMaker Hyperparameter tuning job for Kubernetes. | ||
| name: amazon-sagemaker-hyperparametertuningjob | ||
| version: 1.0.0 | ||
| description: A Helm chart for deploying a SageMaker HyperParameter tuning job from Kubernetes. | ||
| maintainers: | ||
| - name: Gautam Kumar | ||
| email: [email protected] | ||
| - name: Cade Daniel | ||
| email: [email protected] | ||
| - name: Nicholas Thomson | ||
| email: [email protected] | ||
| - name: Meghna Baijal | ||
| email: [email protected] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,8 @@ | ||
| Thanks for installing the {{ .Chart.Name }}. | ||
| Successfully deployed a new hyperparameter tuning job chart. | ||
|
|
||
| Your release is named {{ .Release.Name }}. | ||
|
|
||
| To learn more about the release, try: | ||
|
|
||
| $ helm status {{ .Release.Name }} | ||
| $ helm get {{ .Release.Name }} | ||
|
|
||
| To use the latest features, try adding attributes to yaml by generating it: | ||
|
|
||
| $ helm install <directory of charts> --debug --dry-run | ||
| $ helm get all {{ .Release.Name }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,57 +1,57 @@ | ||
| name: xgboost-mnist-hpo | ||
| spec: | ||
| instancecount: 1 | ||
| instancetype: ml.m4.xlarge | ||
| volumesize: 35 | ||
| maxruntimeinseconds: 86400 | ||
| rolearn: arn:aws:iam::123456789012:role/service-role/AmazonSageMaker-ExecutionRole | ||
| region: us-west-2 | ||
| image: 433757028032.dkr.ecr.us-west-2.amazonaws.com/xgboost:1 | ||
| enablenetworkisolation: true | ||
| enableintercontainertrafficencryption: false | ||
| traininginputmode: File | ||
| hyperparametertuningjobconfig: | ||
| maxnumberoftrainingjobs: 10 | ||
| maxparalleltrainingjobs: 10 | ||
| strategy: Bayesian | ||
| hyperparametertuningjobobjective: | ||
| type: Minimize | ||
| metricname: validation:error | ||
| integerparameterranges: | ||
| name: num_round | ||
| minvalue: 10 | ||
| maxvalue: 20 | ||
| scalingtype: Linear | ||
| trainingjobconfig: | ||
| hyperparameters: | ||
| base_score: '0.5' | ||
| booster: gbtree | ||
| csv_weights: '0' | ||
| dsplit: row | ||
| grow_policy: depthwise | ||
| lambda_bias: '0.0' | ||
| max_bin: '256' | ||
| max_leaves: '0' | ||
| normalize_type: tree | ||
| objective: reg:linear | ||
| one_drop: '0' | ||
| prob_buffer_row: '1.0' | ||
| process_type: default | ||
| rate_drop: '0.0' | ||
| refresh_leaf: '1' | ||
| sample_type: uniform | ||
| scale_pos_weight: '1.0' | ||
| silent: '0' | ||
| sketch_eps: '0.03' | ||
| skip_drop: '0.0' | ||
| tree_method: auto | ||
| tweedie_variance_power: '1.5' | ||
| updater: grow_colmaker,prune | ||
| inputdataconfig: | ||
| - channel: train | ||
| s3: | ||
| s3uri: s3://my-bucket/xgboost-mnist/train/ | ||
| - channel: validation | ||
| s3: | ||
| s3uri: s3://my-bucket/xgboost-mnist/validation/ | ||
| outputpath: s3://my-bucket/xgboost-mnist/xgboost/ | ||
| instanceCount: 1 | ||
| instanceType: ml.m4.xlarge | ||
| volumeSizeInGB: 35 | ||
| maxRuntimeInSeconds: 86400 | ||
| roleArn: arn:aws:iam::123456789012:role/service-role/AmazonSageMaker-ExecutionRole | ||
| region: us-west-2 | ||
| image: 433757028032.dkr.ecr.us-west-2.amazonaws.com/xgboost:1 | ||
| enableNetworkIsolation: true | ||
| enableInterContainerTrafficEncryption: false | ||
| trainingInputMode: File | ||
| hyperparameterTuningJobConfig: | ||
| maxNumberOfTrainingJobs: 10 | ||
| maxParallelTrainingJobs: 10 | ||
| strategy: Bayesian | ||
| hyperparameterTuningJobObjective: | ||
| type: Minimize | ||
| metricName: validation:error | ||
| integerParameterRanges: | ||
| name: num_round | ||
| minValue: 10 | ||
| maxValue: 20 | ||
| scalingType: Linear | ||
| trainingJobConfig: | ||
| hyperparameters: | ||
| base_score: '0.5' | ||
| booster: gbtree | ||
| csv_weights: '0' | ||
| dsplit: row | ||
| grow_policy: depthwise | ||
| lambda_bias: '0.0' | ||
| max_bin: '256' | ||
| max_leaves: '0' | ||
| normalize_type: tree | ||
| objective: reg:linear | ||
| one_drop: '0' | ||
| prob_buffer_row: '1.0' | ||
| process_type: default | ||
| rate_drop: '0.0' | ||
| refresh_leaf: '1' | ||
| sample_type: uniform | ||
| scale_pos_weight: '1.0' | ||
| silent: '0' | ||
| sketch_eps: '0.03' | ||
| skip_drop: '0.0' | ||
| tree_method: auto | ||
| tweedie_variance_power: '1.5' | ||
| updater: grow_colmaker,prune | ||
| inputDataConfig: | ||
| - channel: train | ||
| s3: | ||
| s3Uri: s3://my-bucket/xgboost-mnist/train/ | ||
| - channel: validation | ||
| s3: | ||
| s3Uri: s3://my-bucket/xgboost-mnist/validation/ | ||
| outputPath: s3://my-bucket/xgboost-mnist/xgboost/ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is todo ? @cadedaniel can u confirm that spec will work just that helm chart needs policing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah nick made a task for these https://issues.amazon.com/issues/P32170625