This repository was archived by the owner on Jul 19, 2023. It is now read-only.
Fix broken canary container Dockerfile #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadedaniel
reviewed
Jan 21, 2020
tests/images/Dockerfile.canary
Outdated
| @@ -7,11 +7,11 @@ RUN apt-get update && apt-get install -y curl \ | |||
| python-pip \ | |||
| vim \ | |||
| sudo | |||
|
|
|||
There was a problem hiding this comment.
nit: remove unnecessary whitespace
tests/images/Dockerfile.canary
Outdated
| RUN pip install awscli | ||
|
|
||
| # Install yq | ||
| RUN sudo add-apt-repository ppa:rmescandon/yq && apt update && apt install -y yq | ||
| RUN apt-get update && apt install -y apt-transport-https ca-certificates curl gnupg-agent software-properties-common && sudo add-apt-repository ppa:rmescandon/yq && apt update && apt install -y yq |
There was a problem hiding this comment.
Why was this necessary? Can you update comment?
There was a problem hiding this comment.
In body of pull request - you need software-properties-common to use the add-apt-repository command.
There was a problem hiding this comment.
Ah sorry I missed. Weird that it is failing now.
Can you still update yq comment?
There was a problem hiding this comment.
ignore I saw outdated change
cadedaniel
approved these changes
Jan 21, 2020
tests/images/Dockerfile.canary
Outdated
| RUN pip install awscli | ||
|
|
||
| # Install yq | ||
| RUN sudo add-apt-repository ppa:rmescandon/yq && apt update && apt install -y yq | ||
| RUN apt-get update && apt install -y apt-transport-https ca-certificates curl gnupg-agent software-properties-common && sudo add-apt-repository ppa:rmescandon/yq && apt update && apt install -y yq |
There was a problem hiding this comment.
Ah sorry I missed. Weird that it is failing now.
Can you still update yq comment?
RedbackThomson
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The canary Dockerfile was failing due to the necessary
software-properties-commonpackage not being installed before callingadd-apt-repository.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.